[interpreter] Implement static loop depth tracking.

[interpreter] Implement static loop depth tracking.

This adds tracking of the loop depth to the {BytecodeGenerator} in order
to statically determine the loop nesting level for {OsrPoll} bytecodes.

R=rmcilroy@chromium.org
BUG=v8:4764
Committed: https://crrev.com/7bb24abe03b4ce00699a2d61284070e221f12fd5
Cr-Commit-Position: refs/heads/master@{#38064}

[Michael Starzinger, 2016-07-25 13:42:35]

Description was changed from

==========
[interpreter] Implement static loop depth tracking.

This adds tracking of the loop depth to the {BytecodeGenerator} in order
to statically determine the loop nesting level for {OsrPoll} bytecodes.

R=
BUG=v8:4764
==========

to

==========
[interpreter] Implement static loop depth tracking.

This adds tracking of the loop depth to the {BytecodeGenerator} in order
to statically determine the loop nesting level for {OsrPoll} bytecodes.

R=rmcilroy@chromium.org
BUG=v8:4764
==========

[Michael Starzinger, 2016-07-25 13:42:35]

mstarzinger@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-07-26 09:28:52]

LGTM, thanks.

https://codereview.chromium.org/2176183002/diff/1/src/interpreter/bytecode-ge...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2176183002/diff/1/src/interpreter/bytecode-ge...
src/interpreter/bytecode-generator.cc:273: generator()->loop_depth_--;  //
Decrement tracked loop depth.
Not sure the comments are necessary, pretty self explanatory, but I'm easy
either way :).

[Michael Starzinger, 2016-07-26 09:46:02]

https://codereview.chromium.org/2176183002/diff/1/src/interpreter/bytecode-ge...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2176183002/diff/1/src/interpreter/bytecode-ge...
src/interpreter/bytecode-generator.cc:273: generator()->loop_depth_--;  //
Decrement tracked loop depth.
On 2016/07/26 09:28:52, rmcilroy wrote:
> Not sure the comments are necessary, pretty self explanatory, but I'm easy
> either way :).

Done. I mostly do this to trick clang-format into not uglifying my code.

[Michael Starzinger, 2016-07-26 10:46:26]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 10:46:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 11:02:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 11:02:29]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Michael Starzinger, 2016-07-26 15:18:15]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 15:18:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 15:39:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 15:39:44]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-07-26 15:40:19]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-07-26 15:40:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2176183002/#ps60001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-07-26 15:40:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 15:42:01]

Description was changed from

==========
[interpreter] Implement static loop depth tracking.

This adds tracking of the loop depth to the {BytecodeGenerator} in order
to statically determine the loop nesting level for {OsrPoll} bytecodes.

R=rmcilroy@chromium.org
BUG=v8:4764
==========

to

==========
[interpreter] Implement static loop depth tracking.

This adds tracking of the loop depth to the {BytecodeGenerator} in order
to statically determine the loop nesting level for {OsrPoll} bytecodes.

R=rmcilroy@chromium.org
BUG=v8:4764
==========

[commit-bot: I haz the power, 2016-07-26 15:42:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-26 15:44:57]

Description was changed from

==========
[interpreter] Implement static loop depth tracking.

This adds tracking of the loop depth to the {BytecodeGenerator} in order
to statically determine the loop nesting level for {OsrPoll} bytecodes.

R=rmcilroy@chromium.org
BUG=v8:4764
==========

to

==========
[interpreter] Implement static loop depth tracking.

This adds tracking of the loop depth to the {BytecodeGenerator} in order
to statically determine the loop nesting level for {OsrPoll} bytecodes.

R=rmcilroy@chromium.org
BUG=v8:4764

Committed: https://crrev.com/7bb24abe03b4ce00699a2d61284070e221f12fd5
Cr-Commit-Position: refs/heads/master@{#38064}
==========

[commit-bot: I haz the power, 2016-07-26 15:44:58]

Patchset 4 (id:??) landed as
https://crrev.com/7bb24abe03b4ce00699a2d61284070e221f12fd5
Cr-Commit-Position: refs/heads/master@{#38064}