Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2176153002: Layout test of PerformanceResourceTiming for multipart (Closed)

Created:
4 years, 5 months ago by Adam Rice
Modified:
4 years, 4 months ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Layout test of PerformanceResourceTiming for multipart PerformanceResourceTiming fields should be correctly initialised for multipart images. They are not, so this CL includes an expectation that the test will fail. BUG=631004 Committed: https://crrev.com/d0441c41caadbe2029de72434ae7712dccf03662 Cr-Commit-Position: refs/heads/master@{#408938}

Patch Set 1 #

Patch Set 2 : Poll until entry available. Expect failure. #

Total comments: 2

Patch Set 3 : Comment out failing assertions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-multipart.html View 1 2 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Adam Rice
4 years, 4 months ago (2016-07-29 10:29:55 UTC) #3
Kunihiko Sakamoto
https://codereview.chromium.org/2176153002/diff/20001/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-multipart-expected.txt File third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-multipart-expected.txt (right): https://codereview.chromium.org/2176153002/diff/20001/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-multipart-expected.txt#newcode2 third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-multipart-expected.txt:2: FAIL PerformanceResourceTiming multipart image assert_greater_than: encodedBodySize expected a number ...
4 years, 4 months ago (2016-08-01 02:15:16 UTC) #4
Adam Rice
https://codereview.chromium.org/2176153002/diff/20001/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-multipart-expected.txt File third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-multipart-expected.txt (right): https://codereview.chromium.org/2176153002/diff/20001/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-multipart-expected.txt#newcode2 third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-multipart-expected.txt:2: FAIL PerformanceResourceTiming multipart image assert_greater_than: encodedBodySize expected a number ...
4 years, 4 months ago (2016-08-01 08:49:13 UTC) #7
Kunihiko Sakamoto
lgtm
4 years, 4 months ago (2016-08-01 09:36:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176153002/40001
4 years, 4 months ago (2016-08-01 11:12:18 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-01 11:15:33 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 11:17:12 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d0441c41caadbe2029de72434ae7712dccf03662
Cr-Commit-Position: refs/heads/master@{#408938}

Powered by Google App Engine
This is Rietveld 408576698