Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2176133002: Revert of [heap] Remove black pages and use black areas instead. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Remove black pages and use black areas instead. (patchset #6 id:100001 of https://codereview.chromium.org/2160613002/ ) Reason for revert: Suspected to cause crbug.com/630969 Original issue's description: > [heap] Remove black pages and use black areas instead. > > BUG=630386 > LOG=n > > Committed: https://crrev.com/b008a0d5a3db80a854cb93d9c94d67bf2d780f2c > Cr-Commit-Position: refs/heads/master@{#37967} TBR=ulan@chromium.org,hpayer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=630386 Committed: https://crrev.com/5cbe34bb46141ca30780a61b207d160ac88ecbcd Cr-Commit-Position: refs/heads/master@{#38006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -311 lines) Patch
M src/heap/heap.cc View 4 chunks +6 lines, -18 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +4 lines, -9 lines 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +3 lines, -13 lines 0 comments Download
M src/heap/mark-compact.cc View 11 chunks +72 lines, -27 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +8 lines, -26 lines 0 comments Download
M src/heap/marking.h View 2 chunks +19 lines, -92 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 3 chunks +14 lines, -5 lines 0 comments Download
M src/heap/spaces.cc View 7 chunks +22 lines, -58 lines 0 comments Download
M src/heap/spaces-inl.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M test/unittests/heap/marking-unittest.cc View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yang
Created Revert of [heap] Remove black pages and use black areas instead.
4 years, 5 months ago (2016-07-25 09:46:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176133002/1
4 years, 5 months ago (2016-07-25 09:46:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 10:14:30 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 10:17:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cbe34bb46141ca30780a61b207d160ac88ecbcd
Cr-Commit-Position: refs/heads/master@{#38006}

Powered by Google App Engine
This is Rietveld 408576698