Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2176123002: Fix a threading issue and modernize the use of scoped_refptr in the on-demand update checker. (Closed)

Created:
4 years, 5 months ago by grt (UTC plus 2)
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a threading issue and modernize the use of scoped_refptr in the on-demand update checker. The vector of delegates_ was previously being walked on the FILE thread. This could lead to a crash if a new delegate were to be added on the UI thread. Now, the driver bounces back to the UI thread to send progress updates to the delegates. Also changes the use of scoped_refptr to be up-to-date with current style. BUG=none R=pmonette@chromium.org Committed: https://crrev.com/4fe383ad8010911173d08a19baa3805d9d6f9269 Cr-Commit-Position: refs/heads/master@{#407726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -28 lines) Patch
M chrome/browser/google/google_update_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_win.cc View 13 chunks +45 lines, -27 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
grt (UTC plus 2)
PTAL
4 years, 5 months ago (2016-07-25 08:35:05 UTC) #3
Patrick Monette
lgtm
4 years, 5 months ago (2016-07-25 17:23:56 UTC) #7
grt (UTC plus 2)
+PK for OWNERS review. Please feel at liberty to check the CQ box if it ...
4 years, 5 months ago (2016-07-25 17:28:05 UTC) #10
Peter Kasting
LGTM
4 years, 5 months ago (2016-07-25 19:02:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176123002/1
4 years, 4 months ago (2016-07-26 06:55:32 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 06:59:07 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 07:00:35 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fe383ad8010911173d08a19baa3805d9d6f9269
Cr-Commit-Position: refs/heads/master@{#407726}

Powered by Google App Engine
This is Rietveld 408576698