src/runtime/runtime-forin.cc - Issue 2176113009: [keys] Trigger [[getOwnPropertyDescriptor]] trap for Object.keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-forin.cc

Issue 2176113009: [keys] Trigger [[getOwnPropertyDescriptor]] trap for Object.keys (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: eval scoping is hard Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-forin.cc

diff --git a/src/runtime/runtime-forin.cc b/src/runtime/runtime-forin.cc

index 48ddebb672089b2337eceeea0156d8c314815b28..0d624e97d65844158dc32eebc52639fd134e1d78 100644

--- a/src/runtime/runtime-forin.cc

+++ b/src/runtime/runtime-forin.cc

@@ -26,7 +26,6 @@ MaybeHandle<HeapObject> Enumerate(Handle<JSReceiver> receiver) {

FastKeyAccumulator accumulator(isolate, receiver,

KeyCollectionMode::kIncludePrototypes,

ENUMERABLE_STRINGS);

- accumulator.set_filter_proxy_keys(false);

accumulator.set_is_for_in(true);

// Test if we have an enum cache for {receiver}.

if (!accumulator.is_receiver_simple_enum()) {

« no previous file with comments | « src/keys.cc ('k') | test/mjsunit/es6/proxies-keys.js » ('j') | no next file with comments »