Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2176113005:
Change FYI win clang builders from official to official_optimize. (Closed)
|
Created:
4 years, 4 months ago by Dirk Pranke Modified:
4 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange FYI win clang builders from official to official_optimize.
This changes the config settings for the builders so that they don't
need to pull internal files.
TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org
NOTRY=true
BUG=623659, 630095
Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac
Cr-Commit-Position: refs/heads/master@{#407862}
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
TBR'ing to fix the FYI builders. When thakis@ gets back from vacation we can discuss/revisit whether these builders really need to be full official builds or just use the official_optimize settings like LTCG.
Description was changed from ========== Chang FYI win clang builders from official to official_optimize. This changes the config settings for the builders so that they don't need to pull internal files. TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org BUG=623659, 630095 ========== to ========== Chang FYI win clang builders from official to official_optimize. This changes the config settings for the builders so that they don't need to pull internal files. TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org BUG=623659, 630095 ==========
Description was changed from ========== Chang FYI win clang builders from official to official_optimize. This changes the config settings for the builders so that they don't need to pull internal files. TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org BUG=623659, 630095 ========== to ========== Change FYI win clang builders from official to official_optimize. This changes the config settings for the builders so that they don't need to pull internal files. TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org BUG=623659, 630095 ==========
Description was changed from ========== Change FYI win clang builders from official to official_optimize. This changes the config settings for the builders so that they don't need to pull internal files. TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org BUG=623659, 630095 ========== to ========== Change FYI win clang builders from official to official_optimize. This changes the config settings for the builders so that they don't need to pull internal files. TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org NOTRY=true BUG=623659, 630095 ==========
The CQ bit was unchecked by dpranke@chromium.org
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Change FYI win clang builders from official to official_optimize. This changes the config settings for the builders so that they don't need to pull internal files. TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org NOTRY=true BUG=623659, 630095 ========== to ========== Change FYI win clang builders from official to official_optimize. This changes the config settings for the builders so that they don't need to pull internal files. TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org NOTRY=true BUG=623659, 630095 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Change FYI win clang builders from official to official_optimize. This changes the config settings for the builders so that they don't need to pull internal files. TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org NOTRY=true BUG=623659, 630095 ========== to ========== Change FYI win clang builders from official to official_optimize. This changes the config settings for the builders so that they don't need to pull internal files. TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org NOTRY=true BUG=623659, 630095 Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac Cr-Commit-Position: refs/heads/master@{#407862} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac Cr-Commit-Position: refs/heads/master@{#407862}
Message was sent while issue was closed.
Thanks for fixing. We're using these bots to do size comparisons against MSVC-built official Chrome builds, and I worry that excluding the internal sources will skew that comparison. (Also we want to make sure we can build *all* of Chrome.) Why can't these pull the internal sources anymore?
Message was sent while issue was closed.
Can we revert the bots to gyp until this is figured out? On Jul 26, 2016 9:46 PM, <hans@chromium.org> wrote: > Thanks for fixing. > > We're using these bots to do size comparisons against MSVC-built official > Chrome > builds, and I worry that excluding the internal sources will skew that > comparison. (Also we want to make sure we can build *all* of Chrome.) > > Why can't these pull the internal sources anymore? > > https://codereview.chromium.org/2176113005/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
On 2016/07/26 22:03:47, Nico (ooo until Aug 1) wrote: > Can we revert the bots to gyp until this is figured out? I would prefer not to. I will follow up off-CL since this involves talking about internal/official things.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2198153002/ by thakis@chromium.org. The reason for reverting is: This was landed without review or motivation and breaks tests on these bots..
Message was sent while issue was closed.
On 2016/08/01 17:08:34, Nico (ooo until Aug 1) wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2198153002/ by mailto:thakis@chromium.org. > > The reason for reverting is: This was landed without review or motivation and > breaks tests on these bots.. "Without review" may be correct, but "without motivation" isn't, and I don't know why you think this broke tests, and I'd like to know if (and why) that's true, regardless of whether we end up reverting this or not. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
