Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2176113002: Convert editing/inserting/insert-div-01[1-7].html to use w3c test harness (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/insert-div-01[1-7].html to use w3c test harness This patch converts "editing/inserting/insert-div-01[1-7].html" to use w3c test harness and consolidates into "insert_div_with_attr.html" to simplify test case for ease of maintenance. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/6ad76b419eacefc4d619a212c933484c797ba472 Cr-Commit-Position: refs/heads/master@{#407436}

Patch Set 1 : 2016-07-25T15:18:37 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -1000 lines) Patch
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-011.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-012.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-013.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-014.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-015.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-016.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-017.html View 1 chunk +0 lines, -46 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/inserting/insert_div_with_attr.html View 1 chunk +153 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-011-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-011-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-012-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-012-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-013-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-013-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-014-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-014-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-015-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-015-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-016-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-016-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-017-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-017-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-011-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-011-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-012-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-012-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-013-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-013-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-014-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-014-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-015-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-015-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-016-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-016-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-017-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-017-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-011-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-011-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-012-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-012-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-013-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-013-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-014-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-014-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-015-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-015-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-016-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-016-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-017-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-017-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-25 07:26:07 UTC) #7
Xiaocheng
lgtm
4 years, 5 months ago (2016-07-25 07:55:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176113002/1
4 years, 5 months ago (2016-07-25 08:23:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 09:24:08 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 09:25:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ad76b419eacefc4d619a212c933484c797ba472
Cr-Commit-Position: refs/heads/master@{#407436}

Powered by Google App Engine
This is Rietveld 408576698