Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2176103002: Removed Dead Code (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed reference to delete file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -145 lines) Patch
M runtime/observatory/lib/elements.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/logging.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/observatory/lib/src/elements/sliding_checkbox.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D runtime/observatory/lib/src/elements/sliding_checkbox.html View 1 chunk +0 lines, -90 lines 0 comments Download
D runtime/observatory/lib/src/elements/vm_ref.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D runtime/observatory/lib/src/elements/vm_ref.html View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
cbernaschina
4 years, 4 months ago (2016-07-25 00:24:02 UTC) #2
cbernaschina
4 years, 4 months ago (2016-07-25 00:24:03 UTC) #4
Cutch
lgtm
4 years, 4 months ago (2016-07-25 14:03:37 UTC) #5
rmacnak
lgtm https://chromiumcodereview.appspot.com/2176103002/diff/1/runtime/observatory/observatory_sources.gypi File runtime/observatory/observatory_sources.gypi (right): https://chromiumcodereview.appspot.com/2176103002/diff/1/runtime/observatory/observatory_sources.gypi#newcode177 runtime/observatory/observatory_sources.gypi:177: 'lib/src/elements/vm_ref.dart', Deleted https://chromiumcodereview.appspot.com/2176103002/diff/1/runtime/observatory/observatory_sources.gypi#newcode178 runtime/observatory/observatory_sources.gypi:178: 'lib/src/elements/vm_ref.html', Deleted
4 years, 4 months ago (2016-07-25 16:57:15 UTC) #6
cbernaschina
https://codereview.chromium.org/2176103002/diff/1/runtime/observatory/observatory_sources.gypi File runtime/observatory/observatory_sources.gypi (right): https://codereview.chromium.org/2176103002/diff/1/runtime/observatory/observatory_sources.gypi#newcode177 runtime/observatory/observatory_sources.gypi:177: 'lib/src/elements/vm_ref.dart', On 2016/07/25 16:57:15, rmacnak wrote: > Deleted Done. ...
4 years, 4 months ago (2016-07-25 17:08:31 UTC) #7
cbernaschina
4 years, 4 months ago (2016-07-25 17:09:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a2b7cf90676af644ac400c0bd6e360bab8844e66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698