Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart

Issue 2176093002: Use Timer and not AnimationFrame during Observatory UI tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart b/runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart
index e6b3bc2552dc3fac29f4a995dad198c58e248b94..7a08e53d56ba689c890c74e6594194f7f81346ca 100644
--- a/runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart
+++ b/runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart
@@ -4,23 +4,27 @@
import 'dart:html';
import 'dart:async';
import 'package:unittest/unittest.dart';
-import 'package:observatory/models.dart';
+import 'package:observatory/models.dart' as M;
import 'package:observatory/mocks.dart';
+import 'package:observatory/src/elements/helpers/rendering_queue.dart';
import 'package:observatory/src/elements/nav/notify_exception.dart';
main() {
NavNotifyExceptionElement.tag.ensureRegistration();
- final ConnectionException exception =
+ final TimedRenderingBarrier barrier = new TimedRenderingBarrier();
+ final RenderingQueue queue = new RenderingQueue.fromBarrier(barrier);
+
+ final M.ConnectionException exception =
new ConnectionExceptionMock(message: 'message');
test('instantiation', () {
final NavNotifyExceptionElement e =
- new NavNotifyExceptionElement(exception);
+ new NavNotifyExceptionElement(exception);
expect(e, isNotNull, reason: 'element correctly created');
});
test('elements created after attachment', () async {
- final NavNotifyExceptionElement e =
- new NavNotifyExceptionElement(exception);
+ final NavNotifyExceptionElement e = new NavNotifyExceptionElement(exception,
+ queue: queue);
document.body.append(e);
await e.onRendered.first;
expect(e.children.length, isNonZero, reason: 'has elements');
@@ -32,13 +36,14 @@ main() {
NavNotifyExceptionElement e;
StreamSubscription sub;
setUp(() async {
- e = new NavNotifyExceptionElement(exception);
+ e = new NavNotifyExceptionElement(exception, queue: queue);
document.body.append(e);
await e.onRendered.first;
});
- tearDown(() {
+ tearDown(() async {
sub.cancel();
e.remove();
+ await e.onRendered.first;
});
test('navigation after connect', () async {
sub = window.onPopState.listen(expectAsync((_) {}, count: 1,

Powered by Google App Engine
This is Rietveld 408576698