Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.dart

Issue 2176093002: Use Timer and not AnimationFrame during Observatory UI tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.dart b/runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.dart
index 27bf79cac88b2e13d45e3ceb0e1aed6949b150f6..7cc0259a33922d6766bac212e49f9c470bb880c3 100644
--- a/runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.dart
@@ -6,12 +6,16 @@ import 'dart:async';
import 'package:unittest/unittest.dart';
import 'package:observatory/models.dart';
import 'package:observatory/mocks.dart';
+import 'package:observatory/src/elements/helpers/rendering_queue.dart';
import 'package:observatory/src/elements/nav/menu.dart';
import 'package:observatory/src/elements/nav/isolate_menu.dart';
main(){
NavIsolateMenuElement.tag.ensureRegistration();
+ final TimedRenderingBarrier barrier = new TimedRenderingBarrier();
+ final RenderingQueue queue = new RenderingQueue.fromBarrier(barrier);
+
final String tag = NavMenuElement.tag.name;
StreamController<IsolateUpdateEvent> updatesController;
@@ -36,7 +40,7 @@ main(){
});
test('elements created after attachment', () async {
final NavIsolateMenuElement e = new NavIsolateMenuElement(ref,
- updatesController.stream);
+ updatesController.stream, queue: queue);
document.body.append(e);
await e.onRendered.first;
expect(e.shadowRoot.children.length, isNonZero, reason: 'has elements');
@@ -47,7 +51,7 @@ main(){
group('updates', () {
test('are correctly listen', () async {
final NavIsolateMenuElement e = new NavIsolateMenuElement(ref,
- updatesController.stream);
+ updatesController.stream, queue: queue);
expect(updatesController.hasListener, isFalse);
document.body.append(e);
await e.onRendered.first;
@@ -58,7 +62,7 @@ main(){
});
test('have effects', () async {
final NavIsolateMenuElement e = new NavIsolateMenuElement(ref,
- updatesController.stream);
+ updatesController.stream, queue: queue);
document.body.append(e);
await e.onRendered.first;
expect((e.shadowRoot.querySelector(tag) as NavMenuElement)
@@ -70,6 +74,7 @@ main(){
expect((e.shadowRoot.querySelector(tag) as NavMenuElement)
.label.contains(obj.name), isTrue);
e.remove();
+ await e.onRendered.first;
});
});
}

Powered by Google App Engine
This is Rietveld 408576698