Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2176063002: Updating comment for Proxy::New function (Closed)

Created:
4 years, 5 months ago by danbev
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
git@github.com:danbev/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Updating comment for Proxy::New function The comment for the Proxy::New functions seems inaccurate and is currently identical to Map::New: 3090 /** 3091 * Creates a new empty Map. 3092 */ 3093 static Local<Map> New(Isolate* isolate); This commit updates the comment to describe that it creates a Proxy and not a Map. BUG= Committed: https://crrev.com/47bcea99fbad7e8cc1ad242537f766293777f94d Cr-Commit-Position: refs/heads/master@{#39002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
danbev
4 years, 5 months ago (2016-07-24 06:43:07 UTC) #2
danno
lgtm
4 years, 5 months ago (2016-07-25 12:29:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176063002/1
4 years, 3 months ago (2016-08-30 08:59:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 09:43:45 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 09:44:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47bcea99fbad7e8cc1ad242537f766293777f94d
Cr-Commit-Position: refs/heads/master@{#39002}

Powered by Google App Engine
This is Rietveld 408576698