Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2176043002: Collapse away nested anonymous blocks (Closed)

Created:
4 years, 5 months ago by rhogan
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@467579-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Collapse away nested anonymous blocks https://crrev.com/59d3539fc7ce60355ccf52c00733d33dde5e118a stopped collapsing: LayoutBlockFlow (anonymous) at (0,0) LayoutBlockFlow (anonymous) at (0,0) LayoutInline {SPAN} at (0,0) to LayoutBlockFlow (anonymous) at (0,0) LayoutInline {SPAN} at (0,0) Reinstate that behaviour! BUG=627149 Committed: https://crrev.com/67818d55a1b15b97a96b7a74814e822024b0a346 Cr-Commit-Position: refs/heads/master@{#407551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/collapse-nested-anonymous-block.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/collapse-nested-anonymous-block-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 3 chunks +10 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
rhogan
4 years, 5 months ago (2016-07-23 19:45:14 UTC) #6
eae
LGTM!
4 years, 5 months ago (2016-07-25 18:27:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176043002/1
4 years, 5 months ago (2016-07-25 18:40:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 19:53:44 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 19:56:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67818d55a1b15b97a96b7a74814e822024b0a346
Cr-Commit-Position: refs/heads/master@{#407551}

Powered by Google App Engine
This is Rietveld 408576698