Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2176023002: [Android] Sanitize APK signing file timestamps. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Sanitize APK signing file timestamps. BUG=630931 Committed: https://crrev.com/61e1a7ac087039d43e694c08584724252f9785ce Cr-Commit-Position: refs/heads/master@{#408389}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : clean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M build/android/gyp/finalize_apk.py View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
ghost stip (do not use)
bug: https://bugs.chromium.org/p/chromium/issues/detail?id=630931
4 years, 4 months ago (2016-07-25 05:46:06 UTC) #6
jbudorick
I looked at my runs of chrome_public_test_apk and android_webview_test_apk. None of them seem to have ...
4 years, 4 months ago (2016-07-25 13:12:23 UTC) #7
jbudorick
On 2016/07/25 13:12:23, jbudorick wrote: > I looked at my runs of chrome_public_test_apk and android_webview_test_apk. ...
4 years, 4 months ago (2016-07-25 13:14:19 UTC) #8
ghost stip (do not use)
now that the v8 bug has been fixed, this should work for all binaries. from ...
4 years, 4 months ago (2016-07-26 23:55:51 UTC) #9
jbudorick
agrieve: ptal
4 years, 4 months ago (2016-07-28 13:35:47 UTC) #17
agrieve
lgtm
4 years, 4 months ago (2016-07-28 13:40:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176023002/40001
4 years, 4 months ago (2016-07-28 13:45:56 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-28 14:34:34 UTC) #22
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/61e1a7ac087039d43e694c08584724252f9785ce Cr-Commit-Position: refs/heads/master@{#408389}
4 years, 4 months ago (2016-07-28 14:36:32 UTC) #24
agrieve
4 years, 4 months ago (2016-07-28 17:33:15 UTC) #25
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2191673004/ by agrieve@chromium.org.

The reason for reverting is: Breaking builds:
https://bugs.chromium.org/p/chromium/issues/detail?id=632400.

Powered by Google App Engine
This is Rietveld 408576698