|
|
Description[Android] Sanitize APK signing file timestamps.
BUG=630931
Committed: https://crrev.com/61e1a7ac087039d43e694c08584724252f9785ce
Cr-Commit-Position: refs/heads/master@{#408389}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : clean #
Messages
Total messages: 25 (15 generated)
The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
stip@chromium.org changed reviewers: + stip@chromium.org
I looked at my runs of chrome_public_test_apk and android_webview_test_apk. None of them seem to have been deduped. In two arbitrary runs of chrome_public_test_apk, ChromePublic.apk and snapshot_blob.bin were still different.
On 2016/07/25 13:12:23, jbudorick wrote: > I looked at my runs of chrome_public_test_apk and android_webview_test_apk. None > of them seem to have been deduped. In two arbitrary runs of > chrome_public_test_apk, ChromePublic.apk and snapshot_blob.bin were still > different. ah, I guess this is why you filed https://bugs.chromium.org/p/chromium/issues/detail?id=630935
now that the v8 bug has been fixed, this should work for all binaries. from https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi... and https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi..., both android_webview_test_apk and chrome_public_test_apk have the same binary
The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== CLEAN BEFORE COMMITTING: Make APKs great again! BUG= ========== to ========== [Android] Sanitize APK signing file timestamps. BUG= ==========
Description was changed from ========== [Android] Sanitize APK signing file timestamps. BUG= ========== to ========== [Android] Sanitize APK signing file timestamps. BUG=630931 ==========
jbudorick@chromium.org changed reviewers: + agrieve@chromium.org
agrieve: ptal
lgtm
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Android] Sanitize APK signing file timestamps. BUG=630931 ========== to ========== [Android] Sanitize APK signing file timestamps. BUG=630931 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Android] Sanitize APK signing file timestamps. BUG=630931 ========== to ========== [Android] Sanitize APK signing file timestamps. BUG=630931 Committed: https://crrev.com/61e1a7ac087039d43e694c08584724252f9785ce Cr-Commit-Position: refs/heads/master@{#408389} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/61e1a7ac087039d43e694c08584724252f9785ce Cr-Commit-Position: refs/heads/master@{#408389}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2191673004/ by agrieve@chromium.org. The reason for reverting is: Breaking builds: https://bugs.chromium.org/p/chromium/issues/detail?id=632400. |