Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2176003002: Change naming convention for Android pixel reference images. (Closed)

Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Zhenyao Mo, vmiura
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, cblume, ynovikov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change naming convention for Android pixel reference images. The Nexus 9 and Pixel C on the waterfall have the same GPU device string but different screen resolutions, causing collisions between their pixel test reference images. Add in the model name ("Nexus 9", "AOSP on dragon") to disambiguate them. BUG=624621 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=vmiura@chromium.org,zmo@chromium.org Committed: https://crrev.com/a3aa15c537b8a105184e0bf25a1f5de3ef8c875a Cr-Commit-Position: refs/heads/master@{#407348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M content/test/gpu/gpu_tests/cloud_storage_test_base.py View 3 chunks +9 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Ken Russell (switch to Gerrit)
FYI. CQ'ing TBR'd.
4 years, 5 months ago (2016-07-23 01:08:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176003002/1
4 years, 5 months ago (2016-07-23 01:09:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-23 03:59:06 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 04:01:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3aa15c537b8a105184e0bf25a1f5de3ef8c875a
Cr-Commit-Position: refs/heads/master@{#407348}

Powered by Google App Engine
This is Rietveld 408576698