remoting/client/gl_canvas.cc - Issue 2175963002: [Chromoting] Implement GlRenderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/gl_canvas.cc

Issue 2175963002: [Chromoting] Implement GlRenderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix glUniformMatrix3fv bug in OpenGL ES 2 environment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/gl_canvas.cc

diff --git a/remoting/client/gl_canvas.cc b/remoting/client/gl_canvas.cc

index 03ae0ea0e1d37832a2e67f35cda44565ccdbc3c9..81ad95007b16fed10c3f3b6a33f67d43be2b46bc 100644

--- a/remoting/client/gl_canvas.cc

+++ b/remoting/client/gl_canvas.cc

@@ -84,7 +84,7 @@ GlCanvas::~GlCanvas() {

void GlCanvas::SetNormalizedTransformation(const std::array<float, 9>& matrix) {

DCHECK(thread_checker_.CalledOnValidThread());

- glUniformMatrix3fv(transform_location_, 1, GL_TRUE, matrix.data());

Yuwei 2016/07/25 22:13:55 There was a bug in GlCanvas. It turns out the ES

+ glUniformMatrix3fv(transform_location_, 1, GL_FALSE, matrix.data());

transformation_set_ = true;

}

« no previous file with comments | « remoting/client/gl_canvas.h ('k') | remoting/client/gl_math.h » ('j') | no next file with comments »