Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: remoting/client/gl_canvas.h

Issue 2175963002: [Chromoting] Implement GlRenderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Typo and Move OnFrameRendered() above Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/client/gl_canvas.cc » ('j') | remoting/client/gl_renderer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/gl_canvas.h
diff --git a/remoting/client/gl_canvas.h b/remoting/client/gl_canvas.h
index 8443f89a6c0568bb9f077a1033eef12432c33658..f6155c53852ef50236deb9071170eeaba303dee2 100644
--- a/remoting/client/gl_canvas.h
+++ b/remoting/client/gl_canvas.h
@@ -30,7 +30,8 @@ class GlCanvas {
// Sets the normalized transformation matrix. This matrix defines how the
// canvas should be shown on the view.
- // 3 by 3 transformation matrix, [ m0, m1, m2, m3, m4, m5, m6, m7, m8 ].
+ // 3 by 3 transformation matrix **in column-major order**, i. e.
+ // [ m0, m3, m6, m1, m4, m7, m2, m5, m8 ].
Sergey Ulanov 2016/07/27 17:45:33 This is not intuitive and is hard to work with. Ma
Yuwei 2016/07/27 18:23:10 Done. Wrote separate function for matrix transposi
// The matrix will be multiplied with the positions (with projective space,
// (x, y, 1)) to draw the textures with the right zoom and pan configuration.
//
« no previous file with comments | « no previous file | remoting/client/gl_canvas.cc » ('j') | remoting/client/gl_renderer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698