Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 2175943002: [android]Fulfill a TODO of ianwen, since we have rolled to 24.1.1 (Closed)

Created:
4 years, 5 months ago by Ian Wen
Modified:
4 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android]Fulfill a TODO after the support library roll There was a bug in 23.2.1 where displayMetrics.orientation is wrong after rotation, so we had a workaround. Now we don't need this workaround anymore. BUG=599048 Committed: https://crrev.com/441cd14643e0c2b95899058f4c92d07d54e3bed8 Cr-Commit-Position: refs/heads/master@{#407319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ian Wen
4 years, 5 months ago (2016-07-22 22:27:26 UTC) #3
Ted C
lgtm
4 years, 5 months ago (2016-07-22 22:30:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175943002/1
4 years, 5 months ago (2016-07-22 23:53:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-23 00:37:00 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 00:39:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/441cd14643e0c2b95899058f4c92d07d54e3bed8
Cr-Commit-Position: refs/heads/master@{#407319}

Powered by Google App Engine
This is Rietveld 408576698