content/test/content_browser_test_test.cc - Issue 2175933002: More aggressive IO asserts in content_browsertests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/content_browser_test_test.cc

Issue 2175933002: More aggressive IO asserts in content_browsertests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use 1 less instance of ScopedAllowIO in DumpAccessibilityTestBase::RunTestForPlatform. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/content_browser_test_test.cc

diff --git a/content/test/content_browser_test_test.cc b/content/test/content_browser_test_test.cc

index 54dc1d6a8fbb69eac8b35470f09c8baf1dcf7e66..cbf33947d7990d9e82a87396e49e1cae95a26228 100644

--- a/content/test/content_browser_test_test.cc

+++ b/content/test/content_browser_test_test.cc

@@ -10,6 +10,7 @@

#include "base/single_thread_task_runner.h"

#include "base/strings/utf_string_conversions.h"

#include "base/test/launcher/test_launcher.h"

+#include "base/threading/thread_restrictions.h"

#include "base/threading/thread_task_runner_handle.h"

#include "build/build_config.h"

#include "content/public/browser/render_process_host.h"

@@ -79,6 +80,7 @@ IN_PROC_BROWSER_TEST_F(ContentBrowserTest, RendererCrashCallStack) {

return;

#endif

+ base::ThreadRestrictions::ScopedAllowIO allow_io_for_temp_dir;

base::ScopedTempDir temp_dir;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

base::CommandLine new_test =

@@ -120,6 +122,7 @@ IN_PROC_BROWSER_TEST_F(ContentBrowserTest, MANUAL_BrowserCrash) {

// Tests that browser tests print the callstack on asserts.

IN_PROC_BROWSER_TEST_F(ContentBrowserTest, BrowserCrashCallStack) {

+ base::ThreadRestrictions::ScopedAllowIO allow_io_for_temp_dir;

base::ScopedTempDir temp_dir;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

base::CommandLine new_test =

« no previous file with comments | « content/renderer/dom_serializer_browsertest.cc ('k') | content/test/ppapi/ppapi_test.cc » ('j') | no next file with comments »