PRESUBMIT.py - Issue 2175933002: More aggressive IO asserts in content_browsertests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2175933002: More aggressive IO asserts in content_browsertests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use 1 less instance of ScopedAllowIO in DumpAccessibilityTestBase::RunTestForPlatform. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 7d8c4a762fa178d1871a212610cae17588379f72..4521c6b2518fd4d9adc3cceda58927a1cd6503c1 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -179,11 +179,18 @@ _BANNED_CPP_FUNCTIONS = (

r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$",

r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" +

r"test_info_extractor\.cc$",

+ r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$",

r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",

r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",

+ r"^content[\\\/]test[\\\/]ppapi[\\\/]ppapi_test\.cc$",

r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" +

r"simple_platform_shared_buffer_posix\.cc$",

r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",

+ r"^net[\\\/]cert[\\\/]test_root_certs\.cc$",

+ r"^net[\\\/]test[\\\/]embedded_test_server[\\\/]" +

+ r"embedded_test_server\.cc$",

+ r"^net[\\\/]test[\\\/]spawned_test_server[\\\/]local_test_server\.cc$",

+ r"^net[\\\/]test[\\\/]test_data_directory\.cc$",

r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$",

r"^ui[\\\/]base[\\\/]material_design[\\\/]"

"material_design_controller\.cc$",

« no previous file with comments | « no previous file | content/browser/accessibility/dump_accessibility_browsertest_base.cc » ('j') | no next file with comments »