More aggressive IO asserts in content_browsertests.

content/browser/download/mhtml_generation_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/threading/thread_restrictions.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/common/frame_messages.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/mhtml_generation_params.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "content/shell/browser/shell.h"
@@ skipping 90 matching lines @@
         params, base::Bind(&MHTMLGenerationTest::MHTMLGenerated, this,
                            run_loop.QuitClosure()));
 
     // Block until the MHTML is generated.
     run_loop.Run();
 
     EXPECT_TRUE(has_mhtml_callback_run());
   }
 
   int64_t ReadFileSizeFromDisk(base::FilePath path) {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_to_test_file_size;
     int64_t file_size;
     if (!base::GetFileSize(path, &file_size)) return -1;
     return file_size;
   }
 
   void TestOriginalVsSavedPage(
       const GURL& url,
       const MHTMLGenerationParams params,
       int expected_number_of_frames,
       const std::vector<std::string>& expected_substrings,
@@ skipping 78 matching lines @@
   base::FilePath path(temp_dir_.path());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
 
   GenerateMHTML(path, embedded_test_server()->GetURL("/simple_page.html"));
   ASSERT_FALSE(HasFailure());
 
   // Make sure the actual generated file has some contents.
   EXPECT_GT(file_size(), 0);  // Verify the size reported by the callback.
   EXPECT_GT(ReadFileSizeFromDisk(path), 100);  // Verify the actual file size.
 
-  std::string mhtml;
-  ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
-  EXPECT_THAT(mhtml,
-              HasSubstr("Content-Transfer-Encoding: quoted-printable"));
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
+    std::string mhtml;
+    ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+    EXPECT_THAT(mhtml,
+                HasSubstr("Content-Transfer-Encoding: quoted-printable"));
+  }
 }
 
 class GenerateMHTMLAndExitRendererMessageFilter : public BrowserMessageFilter {
  public:
   GenerateMHTMLAndExitRendererMessageFilter(
       RenderProcessHostImpl* render_process_host)
       : BrowserMessageFilter(FrameMsgStart),
         render_process_host_(render_process_host) {}
 
  protected:
@@ skipping 120 matching lines @@
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, GenerateNonBinaryMHTMLWithImage) {
   base::FilePath path(temp_dir_.path());
   path = path.Append(FILE_PATH_LITERAL("test_binary.mht"));
 
   GURL url(embedded_test_server()->GetURL("/page_with_image.html"));
   GenerateMHTML(path, url);
   ASSERT_FALSE(HasFailure());
   EXPECT_GT(file_size(), 0);  // Verify the size reported by the callback.
   EXPECT_GT(ReadFileSizeFromDisk(path), 100);  // Verify the actual file size.
 
-  std::string mhtml;
-  ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
-  EXPECT_THAT(mhtml, HasSubstr("Content-Transfer-Encoding: base64"));
-  EXPECT_THAT(mhtml, Not(HasSubstr("Content-Transfer-Encoding: binary")));
-  EXPECT_THAT(mhtml, ContainsRegex("Content-Location:.*blank.jpg"));
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
+    std::string mhtml;
+    ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+    EXPECT_THAT(mhtml, HasSubstr("Content-Transfer-Encoding: base64"));
+    EXPECT_THAT(mhtml, Not(HasSubstr("Content-Transfer-Encoding: binary")));
+    EXPECT_THAT(mhtml, ContainsRegex("Content-Location:.*blank.jpg"));
+  }
 }
 
 // Tests that MHTML generated using the binary encoding contains the 'binary'
 // Content-Transfer-Encoding header, and does not contain any base64 encoded
 // parts.
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, GenerateBinaryMHTMLWithImage) {
   base::FilePath path(temp_dir_.path());
   path = path.Append(FILE_PATH_LITERAL("test_binary.mht"));
 
   GURL url(embedded_test_server()->GetURL("/page_with_image.html"));
   MHTMLGenerationParams params(path);
   params.use_binary_encoding = true;
 
   GenerateMHTML(params, url);
   ASSERT_FALSE(HasFailure());
   EXPECT_GT(file_size(), 0);  // Verify the size reported by the callback.
   EXPECT_GT(ReadFileSizeFromDisk(path), 100);  // Verify the actual file size.
 
-  std::string mhtml;
-  ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
-  EXPECT_THAT(mhtml, HasSubstr("Content-Transfer-Encoding: binary"));
-  EXPECT_THAT(mhtml, Not(HasSubstr("Content-Transfer-Encoding: base64")));
-  EXPECT_THAT(mhtml, ContainsRegex("Content-Location:.*blank.jpg"));
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
+    std::string mhtml;
+    ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+    EXPECT_THAT(mhtml, HasSubstr("Content-Transfer-Encoding: binary"));
+    EXPECT_THAT(mhtml, Not(HasSubstr("Content-Transfer-Encoding: base64")));
+    EXPECT_THAT(mhtml, ContainsRegex("Content-Location:.*blank.jpg"));
+  }
 }
 
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, GenerateMHTMLIgnoreNoStore) {
   base::FilePath path(temp_dir_.path());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
 
   GURL url(embedded_test_server()->GetURL("/nostore.html"));
 
   // Generate MHTML without specifying the FailForNoStoreMainFrame policy.
   GenerateMHTML(path, url);
 
   // We expect that there wasn't an error (file size -1 indicates an error.)
   ASSERT_FALSE(HasFailure());
 
   std::string mhtml;
-  ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
+    ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+  }
 
   // Make sure the contents of the body are present.
   EXPECT_THAT(mhtml, HasSubstr("test body"));
 
   // Make sure that URL of the content is present.
   EXPECT_THAT(mhtml, ContainsRegex("Content-Location:.*/nostore.html"));
 }
 
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, GenerateMHTMLObeyNoStoreMainFrame) {
   base::FilePath path(temp_dir_.path());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
 
   GURL url(embedded_test_server()->GetURL("/nostore.html"));
 
   // Generate MHTML, specifying the FailForNoStoreMainFrame policy.
   MHTMLGenerationParams params(path);
   params.cache_control_policy =
       blink::WebFrameSerializerCacheControlPolicy::FailForNoStoreMainFrame;
 
   GenerateMHTML(params, url);
   // We expect that there was an error (file size -1 indicates an error.)
   EXPECT_EQ(-1, file_size());
 
   std::string mhtml;
-  ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
+    ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+  }
 
   // Make sure the contents are missing.
   EXPECT_THAT(mhtml, Not(HasSubstr("test body")));
 }
 
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest,
                        GenerateMHTMLIgnoreNoStoreSubFrame) {
   base::FilePath path(temp_dir_.path());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
 
   GURL url(embedded_test_server()->GetURL("/page_with_nostore_iframe.html"));
 
   // Generate MHTML, specifying the FailForNoStoreMainFrame policy.
   MHTMLGenerationParams params(path);
   params.cache_control_policy =
       blink::WebFrameSerializerCacheControlPolicy::FailForNoStoreMainFrame;
 
   GenerateMHTML(params, url);
   // We expect that there was no error (file size -1 indicates an error.)
   EXPECT_LT(0, file_size());
 
   std::string mhtml;
-  ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
+    ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+  }
 
   EXPECT_THAT(mhtml, HasSubstr("Main Frame"));
   // Make sure that no-store subresources exist in this mode.
   EXPECT_THAT(mhtml, HasSubstr("no-store test body"));
   EXPECT_THAT(mhtml, ContainsRegex("Content-Location:.*nostore.jpg"));
 }
 
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, GenerateMHTMLObeyNoStoreSubFrame) {
   base::FilePath path(temp_dir_.path());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
 
   GURL url(embedded_test_server()->GetURL("/page_with_nostore_iframe.html"));
 
   // Generate MHTML, specifying the FailForNoStoreMainFrame policy.
   MHTMLGenerationParams params(path);
   params.cache_control_policy = blink::WebFrameSerializerCacheControlPolicy::
       SkipAnyFrameOrResourceMarkedNoStore;
 
   GenerateMHTML(params, url);
   // We expect that there was no error (file size -1 indicates an error.)
   EXPECT_LT(0, file_size());
 
   std::string mhtml;
-  ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
+    ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+  }
 
   EXPECT_THAT(mhtml, HasSubstr("Main Frame"));
   // Make sure the contents are missing.
   EXPECT_THAT(mhtml, Not(HasSubstr("no-store test body")));
   // This image comes from a resource marked no-store.
   EXPECT_THAT(mhtml, Not(ContainsRegex("Content-Location:.*nostore.jpg")));
 }
 
 // TODO(crbug.com/615291): These fail on Android under some circumstances.
 #if defined(OS_ANDROID)
@@ skipping 19 matching lines @@
   // No special cache control options so we should see both frames.
   std::vector<std::string> expectations = {
       "Main Frame, normal headers.", "Cache-Control: no-store test body",
   };
   std::vector<std::string> forbidden;
   TestOriginalVsSavedPage(
       embedded_test_server()->GetURL("/page_with_nostore_iframe.html"), params,
       2 /* expected number of frames */, expectations, forbidden);
 
   std::string mhtml;
-  ASSERT_TRUE(base::ReadFileToString(params.file_path, &mhtml));
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
+    ASSERT_TRUE(base::ReadFileToString(params.file_path, &mhtml));
+  }
 }
 
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest,
                        MAYBE_ViewedMHTMLDoesNotContainNoStoreContent) {
   // Generate MHTML, specifying the FailForNoStoreMainFrame policy.
   base::FilePath path(temp_dir_.path());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
   MHTMLGenerationParams params(path);
   params.cache_control_policy = blink::WebFrameSerializerCacheControlPolicy::
       SkipAnyFrameOrResourceMarkedNoStore;
 
   // No special cache control options so we should see both frames.
   std::vector<std::string> expectations = {
       "Main Frame, normal headers.",
   };
   std::vector<std::string> forbidden = {
       "Cache-Control: no-store test body",
   };
   TestOriginalVsSavedPage(
       embedded_test_server()->GetURL("/page_with_nostore_iframe.html"), params,
       2 /* expected number of frames */, expectations, forbidden);
 
   std::string mhtml;
-  ASSERT_TRUE(base::ReadFileToString(params.file_path, &mhtml));
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
+    ASSERT_TRUE(base::ReadFileToString(params.file_path, &mhtml));
+  }
 }
 
 // Test suite that allows testing --site-per-process against cross-site frames.
 // See http://dev.chromium.org/developers/design-documents/site-isolation.
 class MHTMLGenerationSitePerProcessTest : public MHTMLGenerationTest {
  public:
   MHTMLGenerationSitePerProcessTest() {}
 
  protected:
   void SetUpCommandLine(base::CommandLine* command_line) override {
@@ skipping 19 matching lines @@
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationSitePerProcessTest, GenerateMHTML) {
   base::FilePath path(temp_dir_.path());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
 
   GURL url(embedded_test_server()->GetURL(
       "a.com", "/frame_tree/page_with_one_frame.html"));
   GenerateMHTML(path, url);
   ASSERT_FALSE(HasFailure());
 
   std::string mhtml;
-  ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
+    ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
+  }
 
   // Make sure the contents of both frames are present.
   EXPECT_THAT(mhtml, HasSubstr("This page has one cross-site iframe"));
   EXPECT_THAT(mhtml, HasSubstr("This page has no title"));  // From title1.html.
 
   // Make sure that URLs of both frames are present
   // (note that these are single-line regexes).
   EXPECT_THAT(
       mhtml,
       ContainsRegex("Content-Location:.*/frame_tree/page_with_one_frame.html"));
   EXPECT_THAT(mhtml, ContainsRegex("Content-Location:.*/title1.html"));
 }
 
 }  // namespace content