Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2175923002: Fix misdetection of rectangles in SkPath::IsSimpleClosedRect. (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
egdaniel, reed1
CC:
reviews_skia.org, caryclark
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix misdetection of rectangles in SkPath::IsSimpleClosedRect. BUG=chromium:630369 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175923002 Committed: https://skia.googlesource.com/skia/+/057ae8a15ddd2af639a829d63aca29cbc6b1bb57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -70 lines) Patch
M src/core/SkPath.cpp View 1 chunk +41 lines, -70 lines 0 comments Download
M tests/PathTest.cpp View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bsalomon
4 years, 5 months ago (2016-07-22 21:14:12 UTC) #3
egdaniel
lgtm
4 years, 5 months ago (2016-07-22 21:30:33 UTC) #4
reed1
4 years, 5 months ago (2016-07-22 21:49:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175923002/1
4 years, 5 months ago (2016-07-24 12:19:21 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-24 12:37:30 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/057ae8a15ddd2af639a829d63aca29cbc6b1bb57

Powered by Google App Engine
This is Rietveld 408576698