Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2175893002: [Chromedriver] Re-enable ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement on ChromePublic (Closed)

Created:
4 years, 5 months ago by gmanikpure
Modified:
4 years, 5 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Re-enable ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement on ChromePublic BUG=chromedriver:998 Committed: https://crrev.com/970ac6812ff04c3f44ae770b612b093b6feb5d80 Cr-Commit-Position: refs/heads/master@{#407234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/test/chromedriver/test/test_expectations View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
gmanikpure
4 years, 5 months ago (2016-07-22 18:53:33 UTC) #2
samuong
lgtm
4 years, 5 months ago (2016-07-22 18:56:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175893002/1
4 years, 5 months ago (2016-07-22 18:57:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 19:49:12 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/970ac6812ff04c3f44ae770b612b093b6feb5d80 Cr-Commit-Position: refs/heads/master@{#407234}
4 years, 5 months ago (2016-07-22 19:51:06 UTC) #8
gmanikpure
4 years, 5 months ago (2016-07-25 15:57:32 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2176203002/ by gmanikpure@chromium.org.

The reason for reverting is: Test was re-enabled because the bots were running
against old chromedriver build having name "rNone" . But the test is still
failing on correct Head builds that confirms it's a real bug & hence needs to be
disabled again..

Powered by Google App Engine
This is Rietveld 408576698