remove/deprecate SkBitmap::getTexture, as it now always returns false

remove/deprecate SkBitmap::getTexture, as it now always returns false

oh happy day

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175873002

Committed: https://skia.googlesource.com/skia/+/c7ec7c9cabf5c8ad08beb617b99831ece25dacdd

[reed1, 2016-07-22 17:59:20]

Description was changed from

==========
remove/deprecate SkBitmap::getTexture, as it now always returns false

BUG=skia:
==========

to

==========
remove/deprecate SkBitmap::getTexture, as it now always returns false

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175873002
==========

[reed1, 2016-07-22 17:59:34]

reed@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[reed1, 2016-07-22 17:59:43]

Description was changed from

==========
remove/deprecate SkBitmap::getTexture, as it now always returns false

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175873002
==========

to

==========
remove/deprecate SkBitmap::getTexture, as it now always returns false

oh happy day

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175873002
==========

[bsalomon, 2016-07-22 18:06:49]

https://codereview.chromium.org/2175873002/diff/1/src/gpu/GrImageIDTextureAdj...
File src/gpu/GrImageIDTextureAdjuster.cpp (right):

https://codereview.chromium.org/2175873002/diff/1/src/gpu/GrImageIDTextureAdj...
src/gpu/GrImageIDTextureAdjuster.cpp:53: {
{ on prev line?

https://codereview.chromium.org/2175873002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/2175873002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:72: class AutoBitmapTexture : public SkNoncopyable {
Can we just replace this whole thing with

sk_sp<GrTexture> texture = GrRefCachedBitmapTexgture(...);

?

https://codereview.chromium.org/2175873002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:1075: // Unless the bitmap is inherently texture-backed,
we should be respecting the max tile size
Modify comment to remove language about texture-backed?

[reed1, 2016-07-22 21:46:35]

ptal

https://codereview.chromium.org/2175873002/diff/1/src/gpu/GrImageIDTextureAdj...
File src/gpu/GrImageIDTextureAdjuster.cpp (right):

https://codereview.chromium.org/2175873002/diff/1/src/gpu/GrImageIDTextureAdj...
src/gpu/GrImageIDTextureAdjuster.cpp:53: {
On 2016/07/22 18:06:49, bsalomon wrote:
> { on prev line?

I see and use this left-align { when there are multi-line initializers. Maybe
this is not yet standardized.

e.g. SkImage_Raster.cpp, SkImage_Gpu.cpp

I find it helps with readability, since the multi-line inits are at exactly the
same indent as the first line of body

https://codereview.chromium.org/2175873002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/2175873002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:72: class AutoBitmapTexture : public SkNoncopyable {
On 2016/07/22 18:06:49, bsalomon wrote:
> Can we just replace this whole thing with
> 
> sk_sp<GrTexture> texture = GrRefCachedBitmapTexgture(...);
> 
> ?

Done.

https://codereview.chromium.org/2175873002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:1075: // Unless the bitmap is inherently texture-backed,
we should be respecting the max tile size
On 2016/07/22 18:06:49, bsalomon wrote:
> Modify comment to remove language about texture-backed?

Done.

[reed1, 2016-07-22 21:46:41]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 21:46:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-07-22 21:53:15]

afaik -- chrome/blink never use getTexture, so I'm not adding a flag to them
(unless proven otherwise).

[commit-bot: I haz the power, 2016-07-22 22:24:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 22:24:23]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-07-23 01:42:56]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[reed1, 2016-07-24 17:46:45]

other comments?

[robertphillips, 2016-07-25 12:08:29]

lgtm

https://codereview.chromium.org/2175873002/diff/20001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/2175873002/diff/20001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:1326: bitmap.getGenerationID(),
std::move ?

[f(malita), 2016-07-25 12:58:15]

lgtm w/ more moves.

https://codereview.chromium.org/2175873002/diff/20001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/2175873002/diff/20001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:1103: fp = GrBicubicEffect::Make(texture.get(),
std::move(colorSpaceXform), texMatrix,
std::move(texture)?

https://codereview.chromium.org/2175873002/diff/20001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:1106: fp = GrTextureDomainEffect::Make(texture.get(),
std::move(colorSpaceXform), texMatrix,
ditto

https://codereview.chromium.org/2175873002/diff/20001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:1113: fp = GrBicubicEffect::Make(texture.get(),
std::move(colorSpaceXform), texMatrix, tileModes);
ditto

https://codereview.chromium.org/2175873002/diff/20001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:1115: fp = GrSimpleTextureEffect::Make(texture.get(),
std::move(colorSpaceXform), texMatrix, params);
ditto

[bsalomon, 2016-07-25 13:50:08]

https://codereview.chromium.org/2175873002/diff/20001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/2175873002/diff/20001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:1115: fp = GrSimpleTextureEffect::Make(texture.get(),
std::move(colorSpaceXform), texMatrix, params);
On 2016/07/25 12:58:15, f(malita) wrote:
> ditto

We aren't widely using sk_sp for GrResource types yet so none of these functions
actually take a sk_sp. That's future work.

[bsalomon, 2016-07-25 15:03:02]

oh and lgtm

[reed1, 2016-07-25 15:05:47]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-07-25 15:05:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 15:29:12]

Description was changed from

==========
remove/deprecate SkBitmap::getTexture, as it now always returns false

oh happy day

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175873002
==========

to

==========
remove/deprecate SkBitmap::getTexture, as it now always returns false

oh happy day

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175873002

Committed:
https://skia.googlesource.com/skia/+/c7ec7c9cabf5c8ad08beb617b99831ece25dacdd
==========

[commit-bot: I haz the power, 2016-07-25 15:29:14]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c7ec7c9cabf5c8ad08beb617b99831ece25dacdd