AdjustBoundsToEnsureMinimumWindowVisibility may cause unwanted shift if window dimension is small

ash/wm/window_state_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/window_state.h"
 
 #include <utility>
 
 #include "ash/common/material_design/material_design_controller.h"
+#include "ash/common/shelf/wm_shelf.h"
 #include "ash/common/wm/window_state.h"
 #include "ash/common/wm/wm_event.h"
 #include "ash/screen_util.h"
 #include "ash/test/ash_md_test_base.h"
 #include "ash/wm/window_state_aura.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/test/test_window_delegate.h"
 #include "ui/aura/window.h"
 #include "ui/display/screen.h"
 
@@ skipping 381 matching lines @@
 
   window_state->set_allow_set_bounds_in_maximized(false);
   window_state->Maximize();
 
   EXPECT_TRUE(window_state->IsMaximized());
   EXPECT_EQ(work_area, window->bounds());
   window->SetBounds(new_bounds);
   EXPECT_EQ(work_area, window->bounds());
 }
 
+// When there is a workarea bounds changed event caused by shelf layout, the
+// wm::AdjustBoundsToEnsureMinimumWindowVisibility method may cause window
+// bounds change, which leads to the status bubble bug in crbug.com/624806.
+TEST_P(WindowStateTest, AvoidPossibleBoundsChangeIfIgnoredByShelf) {
+  WmShelf* shelf = test::AshTestBase::GetPrimaryShelf();
+  shelf->SetAlignment(ash::SHELF_ALIGNMENT_LEFT);
+  const gfx::Rect display_area =
+      display::Screen::GetScreen()->GetPrimaryDisplay().bounds();
+  std::unique_ptr<aura::Window> window(CreateTestWindowInShellWithId(0));
+  GetWindowState(window.get())->set_ignored_by_shelf(true);
+  // window height should be smaller than wm::kMinimumOnScreenArea,
+  // which is 25 to simulate a status bubble window.
+  gfx::Rect bounds(0, 0, 80, 22);
+  // Ensure the window abuts the bottom of screen.
+  bounds.set_y(display_area.bottom() - bounds.height());
+  window->SetBounds(bounds);
+  EXPECT_EQ(display_area.bottom(), window->bounds().bottom());
+  gfx::Rect expected = window->bounds();
+
+  shelf->SetAlignment(ash::SHELF_ALIGNMENT_BOTTOM);
+  EXPECT_EQ(expected, window->bounds());
+}
+
 // TODO(skuhne): Add more unit test to verify the correctness for the restore
 // operation.
 
 }  // namespace wm
 }  // namespace ash