AdjustBoundsToEnsureMinimumWindowVisibility may cause unwanted shift if window dimension is small

chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.h"
 
 #include "ash/aura/wm_window_aura.h"
 #include "ash/common/wm/mru_window_tracker.h"
 #include "ash/common/wm/window_positioner.h"
 #include "ash/common/wm/window_state.h"
 #include "ash/common/wm_shell.h"
 #include "ash/desktop_background/user_wallpaper_delegate.h"
 #include "ash/root_window_controller.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shelf/shelf_widget.h"
 #include "ash/shell.h"
 #include "ash/wm/window_state_aura.h"
 #include "ash/wm/window_util.h"
 #include "base/macros.h"
 #include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h"
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 #include "chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos.h"
 #include "chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_list.h"
 #include "ui/compositor/layer_animation_observer.h"
 #include "ui/compositor/layer_tree_owner.h"
 #include "ui/wm/core/window_util.h"
 #include "ui/wm/public/activation_client.h"
 
 namespace chrome {
 
 namespace {
 
 // The minimal possible animation time for animations which should happen
@@ skipping 336 matching lines @@
         ash::wm::WindowState* window_state = ash::wm::GetWindowState(window);
         if (owner_->IsWindowOnDesktopOfUser(window, new_account_id_) &&
             !window_state->IsMinimized()) {
           // Several unit tests come here without an activation client.
           aura::client::ActivationClient* client =
               aura::client::GetActivationClient(window->GetRootWindow());
           if (client)
             client->ActivateWindow(window);
         }
       }
+      // The user shelf transition animation may cause browser's status

[sky, 2016/07/25 15:23:40]

Seems like you are working around a bug in the shelf. Why isn't the shelf
updating things correctly?

[Qiang(Joe) Xu, 2016/07/25 21:19:36]

Yes. The reason is shelf animation between transition users. This is one of the
solution, but not solving the root cause. I think showing new users' windows
should start after shelf transition animation finished. It needs more work to
do.

I don't like this solution actually. Let me work more on this.

+      // bubble misplaced. See crbug.com/624806.
+      for (auto* browser : *BrowserList::GetInstance())
+        browser->UpdateStatusBubblePosition();
 
       owner_->notification_blocker()->ActiveUserChanged(new_account_id_);
       break;
     }
     case ANIMATION_STEP_ENDED:
       NOTREACHED();
       break;
   }
 }
 
@@ skipping 43 matching lines @@
         if (itr != window_to_entry_map.end()) {
           windows_by_account_id_[itr->second->show_for_user()].push_back(
               child_window);
         }
       }
     }
   }
 }
 
 }  // namespace chrome