Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2175773002: Revert of Re-land "Fix double-building of v8 in GN builds" (Closed)

Created:
4 years, 5 months ago by timvolodine
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Re-land "Fix double-building of v8 in GN builds" (patchset #2 id:20001 of https://codereview.chromium.org/2171083003/ ) Reason for revert: breaks compile on Android x86 and x64 Builders (dbg) https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29/builds/6738 also see crbug.com/630603 Original issue's description: > Re-land "Fix double-building of v8 in GN builds" > > This re-lands r37926 w/ the needed fix for cross-compiles; we > can only re-use the default toolchain when the host can actually > run it. > > R=machenbach@chromium.org > BUG=629825 > > Committed: https://crrev.com/5b762044b53f988fa9a534fe1a84f9938b3abd75 > Cr-Commit-Position: refs/heads/master@{#37970} TBR=machenbach@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629825, 630603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -37 lines) Patch
M snapshot_toolchain.gni View 1 chunk +17 lines, -37 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
timvolodine
Created Revert of Re-land "Fix double-building of v8 in GN builds"
4 years, 5 months ago (2016-07-22 13:15:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175773002/1
4 years, 5 months ago (2016-07-22 13:15:54 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-22 13:15:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175773002/1
4 years, 5 months ago (2016-07-22 13:17:26 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-22 13:17:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175773002/1
4 years, 5 months ago (2016-07-22 13:19:33 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-22 13:19:35 UTC) #14
timvolodine
lgtm
4 years, 5 months ago (2016-07-22 13:58:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175773002/1
4 years, 5 months ago (2016-07-22 13:58:30 UTC) #17
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-22 13:58:32 UTC) #19
timvolodine
4 years, 5 months ago (2016-07-22 14:01:51 UTC) #20
On 2016/07/22 13:58:07, timvolodine wrote:
> lgtm

this was reverted by v8 sheriff here:
https://codereview.chromium.org/2175693003/

Powered by Google App Engine
This is Rietveld 408576698