components/subresource_filter/core/common/indexed_ruleset.h - Issue 2175763002: Integrate IndexedRuleset into DocumentSubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/common/indexed_ruleset.h

Issue 2175763002: Integrate IndexedRuleset into DocumentSubresourceFilter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/core/common/BUILD.gn ('k') | components/subresource_filter/core/common/indexed_ruleset.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/core/common/indexed_ruleset.h

diff --git a/components/subresource_filter/core/common/indexed_ruleset.h b/components/subresource_filter/core/common/indexed_ruleset.h

index fec6c0c2c4489c1ab89ba91237c2ec895395d6f1..cb04c5af7fdaf209340efadc64d3000e4366b528 100644

--- a/components/subresource_filter/core/common/indexed_ruleset.h

+++ b/components/subresource_filter/core/common/indexed_ruleset.h

@@ -110,9 +110,8 @@ class IndexedRulesetMatcher {

IndexedRulesetMatcher(const uint8_t* buffer, size_t size);

// Returns whether the network request to |url| of |element_type| initiated by

- // |initiator| is allowed to proceed.

- // |element_type| == ELEMENT_TYPE_UNSPECIFIED denotes an unknown or irrelevant

- // type.

+ // |initiator| is allowed to proceed. Always returns true, if the |url| is not

+ // valid or |element_type| == ELEMENT_TYPE_UNSPECIFIED.

bool IsAllowed(const GURL& url,

const url::Origin& initiator,

proto::ElementType element_type) const;

« no previous file with comments | « components/subresource_filter/core/common/BUILD.gn ('k') | components/subresource_filter/core/common/indexed_ruleset.cc » ('j') | no next file with comments »