components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc - Issue 2175763002: Integrate IndexedRuleset into DocumentSubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

Issue 2175763002: Integrate IndexedRuleset into DocumentSubresourceFilter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc ('k') | components/subresource_filter/core/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

index 213e796dac7a9d645ab44bceb3c998466e454fd3..47c1d1e2450f6c3655bf8381b92ab6ebaae4efd6 100644

--- a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

+++ b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

@@ -82,7 +82,7 @@ class SubresourceFilterAgentTest : public ::testing::Test {

void SetTestRulesetToDisallowURLsWithPathSuffix(base::StringPiece suffix) {

base::File ruleset_file;

ASSERT_NO_FATAL_FAILURE(

- test_ruleset_creator_.CreateRulesetToDisallowURLsWithPathSuffix(

+ test_ruleset_creator_.CreateRulesetFileToDisallowURLsWithPathSuffix(

suffix, &ruleset_file));

ruleset_dealer_.SetRulesetFile(std::move(ruleset_file));

}

@@ -116,7 +116,7 @@ class SubresourceFilterAgentTest : public ::testing::Test {

void ExpectLoadAllowed(base::StringPiece url_spec, bool allowed) {

blink::WebURL url = GURL(url_spec);

blink::WebURLRequest::RequestContext request_context =

- blink::WebURLRequest::RequestContextUnspecified;

+ blink::WebURLRequest::RequestContextImage;

EXPECT_EQ(allowed, agent()->filter()->allowLoad(url, request_context));

}