net/spdy/spdy_proxy_client_socket.h - Issue 217573002: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_proxy_client_socket.h

Issue 217573002: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: process error code in quic_stream_factory Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/dns/address_sorter_posix_unittest.cc ('K') | « net/socket/transport_client_socket_pool_unittest.cc ('k') | net/spdy/spdy_proxy_client_socket.cc » ('j') | net/spdy/spdy_proxy_client_socket.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/spdy/spdy_proxy_client_socket.h

diff --git a/net/spdy/spdy_proxy_client_socket.h b/net/spdy/spdy_proxy_client_socket.h

index 3d7933110b43a0c4b6f051bb5026975d619632d4..4c4e8fdf748b2644c9bd4d323e3f2d519a082889 100644

--- a/net/spdy/spdy_proxy_client_socket.h

+++ b/net/spdy/spdy_proxy_client_socket.h

@@ -86,8 +86,8 @@ class NET_EXPORT_PRIVATE SpdyProxyClientSocket : public ProxyClientSocket,

virtual int Write(IOBuffer* buf,

int buf_len,

const CompletionCallback& callback) OVERRIDE;

- virtual bool SetReceiveBufferSize(int32 size) OVERRIDE;

- virtual bool SetSendBufferSize(int32 size) OVERRIDE;

+ virtual int SetReceiveBufferSize(int32 size) OVERRIDE;

+ virtual int SetSendBufferSize(int32 size) OVERRIDE;

virtual int GetPeerAddress(IPEndPoint* address) const OVERRIDE;

virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE;