make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

remoting/protocol/channel_multiplexer.cc

Index: remoting/protocol/channel_multiplexer.cc
diff --git a/remoting/protocol/channel_multiplexer.cc b/remoting/protocol/channel_multiplexer.cc
index 2988f221ff34f4c0abdfc9d1517c480962dc4902..3f7466cf55f07db0abcbaec7a6fdd718953aff03 100644
--- a/remoting/protocol/channel_multiplexer.cc
+++ b/remoting/protocol/channel_multiplexer.cc
@@ -116,25 +116,25 @@ class ChannelMultiplexer::MuxSocket : public net::StreamSocket,
   virtual int Write(net::IOBuffer* buffer, int buffer_len,
                     const net::CompletionCallback& callback) OVERRIDE;
 
-  virtual bool SetReceiveBufferSize(int32 size) OVERRIDE {
+  virtual int SetReceiveBufferSize(int32 size) OVERRIDE {
     NOTIMPLEMENTED();
-    return false;
+    return net::ERR_NOT_IMPLEMENTED;
   }
-  virtual bool SetSendBufferSize(int32 size) OVERRIDE {
+  virtual int SetSendBufferSize(int32 size) OVERRIDE {
     NOTIMPLEMENTED();
-    return false;
+    return net::ERR_NOT_IMPLEMENTED;
   }
 
   virtual int Connect(const net::CompletionCallback& callback) OVERRIDE {
     NOTIMPLEMENTED();
-    return net::ERR_FAILED;
+    return net::ERR_NOT_IMPLEMENTED;

[Ryan Hamilton, 2014/04/08 19:55:11]

Note: this is actually a minor semantic change.  Seems fine, but if we're
grasping at straws, here's a straw :>

[jar (doing other things), 2014/04/08 23:16:26]

I'm going to hold off on this preservation unless the first landing attempt
fails.  Also note that this change is protected by a NOTIMPLEMENTED (and we're
seeing trouble in a debug build).

   }
   virtual void Disconnect() OVERRIDE {
     NOTIMPLEMENTED();
   }
   virtual bool IsConnected() const OVERRIDE {
     NOTIMPLEMENTED();
-    return true;
+    return false;
   }
   virtual bool IsConnectedAndIdle() const OVERRIDE {
     NOTIMPLEMENTED();
@@ -142,11 +142,11 @@ class ChannelMultiplexer::MuxSocket : public net::StreamSocket,
   }
   virtual int GetPeerAddress(net::IPEndPoint* address) const OVERRIDE {
     NOTIMPLEMENTED();
-    return net::ERR_FAILED;
+    return net::ERR_NOT_IMPLEMENTED;

[Ryan Hamilton, 2014/04/08 19:55:11]

Note: this is actually a minor semantic change.  Seems fine, but if we're
grasping at straws, here's a straw :>

[jar (doing other things), 2014/04/08 23:16:26]

Holding off...

   }
   virtual int GetLocalAddress(net::IPEndPoint* address) const OVERRIDE {
     NOTIMPLEMENTED();
-    return net::ERR_FAILED;
+    return net::ERR_NOT_IMPLEMENTED;

[Ryan Hamilton, 2014/04/08 19:55:11]

Note: this is actually a minor semantic change.  Seems fine, but if we're
grasping at straws, here's a straw :>

[jar (doing other things), 2014/04/08 23:16:26]

Holding off...

   }
   virtual const net::BoundNetLog& NetLog() const OVERRIDE {
     NOTIMPLEMENTED();