Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: net/socket/transport_client_socket_pool_unittest.cc

Issue 217573002: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo on Linux Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/transport_client_socket_pool_unittest.cc
diff --git a/net/socket/transport_client_socket_pool_unittest.cc b/net/socket/transport_client_socket_pool_unittest.cc
index ff85847979b692231b4b6558722ab78f47136cdc..425bb8cc421ac4a36695cfc5758bda2e0efc4077 100644
--- a/net/socket/transport_client_socket_pool_unittest.cc
+++ b/net/socket/transport_client_socket_pool_unittest.cc
@@ -145,8 +145,8 @@ class MockClientSocket : public StreamSocket {
const CompletionCallback& callback) OVERRIDE {
return ERR_FAILED;
}
- virtual bool SetReceiveBufferSize(int32 size) OVERRIDE { return true; }
- virtual bool SetSendBufferSize(int32 size) OVERRIDE { return true; }
+ virtual int SetReceiveBufferSize(int32 size) OVERRIDE { return OK; }
+ virtual int SetSendBufferSize(int32 size) OVERRIDE { return OK; }
private:
bool connected_;
@@ -210,8 +210,8 @@ class MockFailingClientSocket : public StreamSocket {
const CompletionCallback& callback) OVERRIDE {
return ERR_FAILED;
}
- virtual bool SetReceiveBufferSize(int32 size) OVERRIDE { return true; }
- virtual bool SetSendBufferSize(int32 size) OVERRIDE { return true; }
+ virtual int SetReceiveBufferSize(int32 size) OVERRIDE { return OK; }
+ virtual int SetSendBufferSize(int32 size) OVERRIDE { return OK; }
private:
const AddressList addrlist_;
@@ -299,8 +299,8 @@ class MockPendingClientSocket : public StreamSocket {
const CompletionCallback& callback) OVERRIDE {
return ERR_FAILED;
}
- virtual bool SetReceiveBufferSize(int32 size) OVERRIDE { return true; }
- virtual bool SetSendBufferSize(int32 size) OVERRIDE { return true; }
+ virtual int SetReceiveBufferSize(int32 size) OVERRIDE { return OK; }
+ virtual int SetSendBufferSize(int32 size) OVERRIDE { return OK; }
private:
void DoCallback(const CompletionCallback& callback) {

Powered by Google App Engine
This is Rietveld 408576698