content/browser/renderer_host/p2p/socket_host_test_utils.cc - Issue 217573002: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_test_utils.cc

Issue 217573002: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix typo on Linux Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/adb/android_usb_socket.cc ('K') | « content/browser/renderer_host/p2p/socket_host_test_utils.h ('k') | content/browser/renderer_host/p2p/socket_host_udp.cc » ('j') | content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_host_test_utils.cc

diff --git a/content/browser/renderer_host/p2p/socket_host_test_utils.cc b/content/browser/renderer_host/p2p/socket_host_test_utils.cc

index 67c461a6b97c64a225ee47521d1ee01f5c366f99..ba40aecf4a45f5109973073b38a81143111e6ab0 100644

--- a/content/browser/renderer_host/p2p/socket_host_test_utils.cc

+++ b/content/browser/renderer_host/p2p/socket_host_test_utils.cc

@@ -103,13 +103,14 @@ void FakeSocket::DoAsyncWrite(scoped_refptr<net::IOBuffer> buf, int buf_len,

callback.Run(buf_len);

}

-bool FakeSocket::SetReceiveBufferSize(int32 size) {

+int FakeSocket::SetReceiveBufferSize(int32 size) {

NOTIMPLEMENTED();

- return false;

+ return net::ERR_NOT_IMPLEMENTED;

}

-bool FakeSocket::SetSendBufferSize(int32 size) {

+int FakeSocket::SetSendBufferSize(int32 size) {

NOTIMPLEMENTED();

- return false;

+ return net::ERR_NOT_IMPLEMENTED;

}

int FakeSocket::Connect(const net::CompletionCallback& callback) {