make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

net/dns/address_sorter_posix_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/address_sorter_posix.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_util.h"
@@ skipping 25 matching lines @@
   virtual ~TestUDPClientSocket() {}
 
   virtual int Read(IOBuffer*, int, const CompletionCallback&) OVERRIDE {
     NOTIMPLEMENTED();
     return OK;
   }
   virtual int Write(IOBuffer*, int, const CompletionCallback&) OVERRIDE {
     NOTIMPLEMENTED();
     return OK;
   }
-  virtual bool SetReceiveBufferSize(int32) OVERRIDE {
-    return true;
+  virtual int SetReceiveBufferSize(int32) OVERRIDE {
+    return OK;
   }
-  virtual bool SetSendBufferSize(int32) OVERRIDE {
-    return true;
+  virtual int SetSendBufferSize(int32) OVERRIDE {
+    return OK;

[wtc, 2014/03/29 13:30:12]

I wonder why these two methods don't have NOTIMPLEMENTED().

[jar (doing other things), 2014/04/01 23:50:39]

My presumption is that this is effectively a mock.

   }
 
   virtual void Close() OVERRIDE {}
   virtual int GetPeerAddress(IPEndPoint* address) const OVERRIDE {
     NOTIMPLEMENTED();
     return OK;
   }
   virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE {
     if (!connected_)
       return ERR_UNEXPECTED;
@@ skipping 257 matching lines @@
   AddMapping("4000::1", "4000::10");  // global unicast
   AddMapping("ff32::2", "fe81::20");  // deprecated link-local multicast
   GetSourceInfo("fe81::20")->deprecated = true;
   const char* addresses[] = { "ff3e::1", "ff32::2", "4000::1", "ff32::1", "::1",
                               "8.0.0.1", NULL };
   const int order[] = { 4, 3, 0, 2, 1, -1 };
   Verify(addresses, order);
 }
 
 }  // namespace net