make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

content/browser/renderer_host/pepper/pepper_tcp_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/pepper/pepper_tcp_socket.h"
 
 #include <string.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 242 matching lines @@
         SendSetOptionACK(PP_ERROR_BADARGUMENT);
         return;
       }
 
       bool result = false;
       if (name == PP_TCPSOCKET_OPTION_SEND_BUFFER_SIZE) {
         if (integer_value > ppapi::TCPSocketShared::kMaxSendBufferSize) {
           SendSetOptionACK(PP_ERROR_BADARGUMENT);
           return;
         }
-        result = tcp_socket->SetSendBufferSize(integer_value);
+        result = tcp_socket->SetSendBufferSize(integer_value) == net::OK;
       } else {
         if (integer_value > ppapi::TCPSocketShared::kMaxReceiveBufferSize) {
           SendSetOptionACK(PP_ERROR_BADARGUMENT);
           return;
         }
-        result = tcp_socket->SetReceiveBufferSize(integer_value);
+        result = tcp_socket->SetReceiveBufferSize(integer_value) == net::OK;
       }
       SendSetOptionACK(result ? PP_OK : PP_ERROR_FAILED);

[wtc, 2014/03/29 13:30:12]

Nit: You can ignore this suggestion.

  int result = net::ERR_UNEXPECTED;
  if (...) {
    ...
    result = tcp_socket->SetSendBufferSize(integer_value);
  } else {
    result = tcp_socket->SetReceiveBufferSize(integer_value);
  }
  SendSetOptionACK(result == net::OK ? PP_OK : PP_ERROR_FAILED);

Note that this method now has an opportunity to do error code mapping (from
net::ERR_xxx to PP_xxx). Maybe you can add a TODO comment.

[jar (doing other things), 2014/04/01 23:50:39]

I made the change, and added a TODO... but assigned to you.  If you know a
better target, I'll use him/her. thx!

       return;
     }
     default: {
       NOTREACHED();
       SendSetOptionACK(PP_ERROR_BADARGUMENT);
       return;
     }
   }
 }
 
@@ skipping 236 matching lines @@
 
   int net_result = socket_->Write(
       write_buffer_.get(),
       write_buffer_->BytesRemaining(),
       base::Bind(&PepperTCPSocket::OnWriteCompleted, base::Unretained(this)));
   if (net_result != net::ERR_IO_PENDING)
     OnWriteCompleted(net_result);
 }
 
 }  // namespace content