make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

net/socket/tcp_socket_libevent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/tcp_socket.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <netdb.h>
 #include <netinet/in.h>
@@ skipping 483 matching lines @@
   //
   // SO_REUSEPORT is provided in MacOS X and iOS.
   int boolean_value = allow ? 1 : 0;
   int rv = setsockopt(socket_, SOL_SOCKET, SO_REUSEADDR, &boolean_value,
                       sizeof(boolean_value));
   if (rv < 0)
     return MapSystemError(errno);
   return OK;
 }
 
-bool TCPSocketLibevent::SetReceiveBufferSize(int32 size) {
+int TCPSocketLibevent::SetReceiveBufferSize(int32 size) {
   DCHECK(CalledOnValidThread());
   int rv = setsockopt(socket_, SOL_SOCKET, SO_RCVBUF,
-      reinterpret_cast<const char*>(&size),
-      sizeof(size));
-  DCHECK(!rv) << "Could not set socket receive buffer size: " << errno;
-  return rv == 0;
+                      reinterpret_cast<const char*>(&size), sizeof(size));
+  return (rv == 0) ? OK : MapSystemError(errno);

[Ryan Hamilton, 2014/04/08 19:55:11]

please DCHECK_NE(0, errno)

[jar (doing other things), 2014/04/08 23:16:26]

Per discussion... I put in a local method to handle the (hopefully) unlikely
errno == 0 event.

 }
 
-bool TCPSocketLibevent::SetSendBufferSize(int32 size) {
+int TCPSocketLibevent::SetSendBufferSize(int32 size) {
   DCHECK(CalledOnValidThread());
   int rv = setsockopt(socket_, SOL_SOCKET, SO_SNDBUF,
-      reinterpret_cast<const char*>(&size),
-      sizeof(size));
-  DCHECK(!rv) << "Could not set socket send buffer size: " << errno;
-  return rv == 0;
+                      reinterpret_cast<const char*>(&size), sizeof(size));
+  return (rv == 0) ? OK : MapSystemError(errno);

[Ryan Hamilton, 2014/04/08 19:55:11]

please DCHECK_NE(0, errno)

[jar (doing other things), 2014/04/08 23:16:26]

handled as above.

 }
 
 bool TCPSocketLibevent::SetKeepAlive(bool enable, int delay) {
   DCHECK(CalledOnValidThread());
   return SetTCPKeepAlive(socket_, enable, delay);
 }
 
 bool TCPSocketLibevent::SetNoDelay(bool no_delay) {
   DCHECK(CalledOnValidThread());
   return SetTCPNoDelay(socket_, no_delay);
@@ skipping 367 matching lines @@
       }
     } else {
       fast_open_status_ = (fast_open_status_ == FAST_OPEN_FAST_CONNECT_RETURN ?
                            FAST_OPEN_SYN_DATA_FAILED :
                            FAST_OPEN_NO_SYN_DATA_FAILED);
     }
   }
 }
 
 }  // namespace net