chrome/browser/push_messaging/push_messaging_browsertest.cc - Issue 2175703002: Implement a task scheduler for BrowsingDataRemover

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_browsertest.cc

Issue 2175703002: Implement a task scheduler for BrowsingDataRemover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bdr-race-condition

Patch Set: Formatting. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profile_resetter/profile_resetter.cc ('k') | chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_browsertest.cc

diff --git a/chrome/browser/push_messaging/push_messaging_browsertest.cc b/chrome/browser/push_messaging/push_messaging_browsertest.cc

index cd5b4409920819a6829f7bd93962cce33e2499ba..491f89961e6d6c89d2caec4e13a00ad7fc0f5572 100644

--- a/chrome/browser/push_messaging/push_messaging_browsertest.cc

+++ b/chrome/browser/push_messaging/push_messaging_browsertest.cc

@@ -1417,9 +1417,9 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,

BrowsingDataRemover* remover =

BrowsingDataRemoverFactory::GetForBrowserContext(GetBrowser()->profile());

BrowsingDataRemoverCompletionObserver observer(remover);

- remover->Remove(BrowsingDataRemover::Unbounded(),

- BrowsingDataRemover::REMOVE_SITE_DATA,

- BrowsingDataHelper::UNPROTECTED_WEB);

+ remover->RemoveAndReply(BrowsingDataRemover::Unbounded(),

+ BrowsingDataRemover::REMOVE_SITE_DATA,

+ BrowsingDataHelper::UNPROTECTED_WEB, &observer);

observer.BlockUntilCompletion();

base::RunLoop run_loop;

« no previous file with comments | « chrome/browser/profile_resetter/profile_resetter.cc ('k') | chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc » ('j') | no next file with comments »