chrome/browser/net/sdch_browsertest.cc - Issue 2175703002: Implement a task scheduler for BrowsingDataRemover

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/sdch_browsertest.cc

Issue 2175703002: Implement a task scheduler for BrowsingDataRemover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bdr-race-condition

Patch Set: Formatting. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/browsing_data/browsing_data_api.cc ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/sdch_browsertest.cc

diff --git a/chrome/browser/net/sdch_browsertest.cc b/chrome/browser/net/sdch_browsertest.cc

index eda2f9f28c93debd3b0b7c2f40966aa5fca12fa4..6a0c05c0d867ea5047bc3cf3bd149e00c6ed9c8d 100644

--- a/chrome/browser/net/sdch_browsertest.cc

+++ b/chrome/browser/net/sdch_browsertest.cc

@@ -408,8 +408,9 @@ class SdchBrowserTest : public InProcessBrowserTest,

BrowsingDataRemover* remover =

BrowsingDataRemoverFactory::GetForBrowserContext(browser()->profile());

BrowsingDataRemoverCompletionObserver completion_observer(remover);

- remover->Remove(BrowsingDataRemover::Period(browsing_data::LAST_HOUR),

- remove_mask, BrowsingDataHelper::UNPROTECTED_WEB);

+ remover->RemoveAndReply(

+ BrowsingDataRemover::Period(browsing_data::LAST_HOUR), remove_mask,

+ BrowsingDataHelper::UNPROTECTED_WEB, &completion_observer);

completion_observer.BlockUntilCompletion();

}