Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

Issue 2175703002: Implement a task scheduler for BrowsingDataRemover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bdr-race-condition
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
index 232aa42414a1a06c6558daeaba3312bbb97d27a5..5940b8d26bca6dfa30f8e2c3acc0b1309aa1d936 100644
--- a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
+++ b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
@@ -315,6 +315,7 @@ void BrowsingDataRemoverFunction::CheckRemovingPluginDataSupported(
void BrowsingDataRemoverFunction::StartRemoving() {
BrowsingDataRemover* remover =
BrowsingDataRemoverFactory::GetForBrowserContext(GetProfile());
+ // TODO(msramek): This restriction is no longer needed. Remove it.
if (remover->is_removing()) {
error_ = extension_browsing_data_api_constants::kOneAtATimeError;
SendResponse(false);
@@ -329,9 +330,9 @@ void BrowsingDataRemoverFunction::StartRemoving() {
// we've generated above. We can use a raw pointer here, as the browsing data
// remover is responsible for deleting itself once data removal is complete.
observer_.Add(remover);
- remover->Remove(
+ remover->RemoveAndReply(
BrowsingDataRemover::TimeRange(remove_since_, base::Time::Max()),
- removal_mask_, origin_type_mask_);
+ removal_mask_, origin_type_mask_, this);
}
int BrowsingDataRemoverFunction::ParseOriginTypeMask(

Powered by Google App Engine
This is Rietveld 408576698