chrome/browser/android/signin/signin_manager_android.cc - Issue 2175703002: Implement a task scheduler for BrowsingDataRemover

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/signin/signin_manager_android.cc

Issue 2175703002: Implement a task scheduler for BrowsingDataRemover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bdr-race-condition

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/preferences/pref_service_bridge.cc ('k') | chrome/browser/browsing_data/browsing_data_remover.h » ('j') | chrome/browser/browsing_data/browsing_data_remover.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/signin/signin_manager_android.cc

diff --git a/chrome/browser/android/signin/signin_manager_android.cc b/chrome/browser/android/signin/signin_manager_android.cc

index 21fc75293a924d9cd9b1995f157753e4da081b41..61d66081b5f4887216d05108ee5df0ba41f94ede 100644

--- a/chrome/browser/android/signin/signin_manager_android.cc

+++ b/chrome/browser/android/signin/signin_manager_android.cc

@@ -59,8 +59,10 @@ class ProfileDataRemover : public BrowsingDataRemover::Observer {

origin_runner_(base::ThreadTaskRunnerHandle::Get()),

remover_(BrowsingDataRemoverFactory::GetForBrowserContext(profile)) {

remover_->AddObserver(this);

- remover_->Remove(BrowsingDataRemover::Unbounded(),

- BrowsingDataRemover::REMOVE_ALL, BrowsingDataHelper::ALL);

+ remover_->RemoveAndReply(BrowsingDataRemover::Unbounded(),

+ BrowsingDataRemover::REMOVE_ALL,

+ BrowsingDataHelper::ALL,

+ this);

}

~ProfileDataRemover() override {}