Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2175693004: Enable Per-Monitor DPI Unless Explicitly Disabled (Closed)

Created:
4 years, 5 months ago by robliao
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Per-Monitor DPI Unless Explicitly Disabled Per Monitor DPI Settings Flags Before After No Flags Disabled Enabled Enable Enabled Enabled Enable + Disabled Disabled Disabled Disabled Disalbed Disabled BUG=426656 Committed: https://crrev.com/23364eecc5d1bb1770f8c22a7c0a320154e3eac7 Cr-Commit-Position: refs/heads/master@{#407508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/app/chrome_exe_main_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
robliao
Preparing to throw the switch on Monday.
4 years, 5 months ago (2016-07-22 21:48:50 UTC) #3
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-22 22:21:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175693004/1
4 years, 5 months ago (2016-07-25 17:08:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 17:51:22 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/23364eecc5d1bb1770f8c22a7c0a320154e3eac7 Cr-Commit-Position: refs/heads/master@{#407508}
4 years, 5 months ago (2016-07-25 17:56:12 UTC) #12
Peter Kasting
This broke --force-device-scale-factor=, which is now ignored. Is that an expected result, and if so, ...
4 years, 4 months ago (2016-07-27 01:58:21 UTC) #13
Peter Kasting
On 2016/07/27 01:58:21, Peter Kasting wrote: > Is that an expected result, and if so, ...
4 years, 4 months ago (2016-07-27 02:00:13 UTC) #14
robliao
4 years, 4 months ago (2016-07-27 02:12:08 UTC) #15
Message was sent while issue was closed.
On 2016/07/27 02:00:13, Peter Kasting wrote:
> On 2016/07/27 01:58:21, Peter Kasting wrote:
> > Is that an expected result, and if so, what is the intended workaround? 
> 
> (By this I don't mean "pass --disable-per-monitor-dpi" as clearly that will go
> away eventually.)

Yup. And that's fixed as of https://codereview.chromium.org/2176183005/

Powered by Google App Engine
This is Rietveld 408576698