Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: scripts/slave/recipes/blink_downstream.py

Issue 2175683003: demo of step.context bot_update issue (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """ 5 """
6 This recipe can be used by components like v8 to verify blink tests with a 6 This recipe can be used by components like v8 to verify blink tests with a
7 low false positive rate. Similar to a trybot, this recipe compares test 7 low false positive rate. Similar to a trybot, this recipe compares test
8 failures from a build with a current component revision with test failures 8 failures from a build with a current component revision with test failures
9 from a build with a pinned component revision. 9 from a build with a pinned component revision.
10 10
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 # Ensure we remember the chromium revision. 131 # Ensure we remember the chromium revision.
132 api.gclient.c.got_revision_mapping['src'] = 'got_cr_revision' 132 api.gclient.c.got_revision_mapping['src'] = 'got_cr_revision'
133 133
134 context = {} 134 context = {}
135 checkout_dir = api.chromium_tests.get_checkout_dir(bot_config) 135 checkout_dir = api.chromium_tests.get_checkout_dir(bot_config)
136 if checkout_dir: 136 if checkout_dir:
137 context['cwd'] = checkout_dir 137 context['cwd'] = checkout_dir
138 138
139 # Run all steps in the checkout dir (consistent with chromium_tests). 139 # Run all steps in the checkout dir (consistent with chromium_tests).
140 with api.step.context(context): 140 with api.step.context(context):
141 # TODO(phajdan.jr): remove redundant **context below once we fix things 141 step_result = api.bot_update.ensure_checkout(force=True)
142 # to behave the same without it.
143 step_result = api.bot_update.ensure_checkout(force=True, **context)
144 142
145 api.chromium.ensure_goma() 143 api.chromium.ensure_goma()
146 144
147 api.chromium.c.project_generator.tool = 'mb' 145 api.chromium.c.project_generator.tool = 'mb'
148 api.chromium.runhooks() 146 api.chromium.runhooks()
149 147
150 api.chromium_tests.run_mb_and_compile( 148 api.chromium_tests.run_mb_and_compile(
151 ['blink_tests'], [], 149 ['blink_tests'], [],
152 name_suffix=' (with patch)', 150 name_suffix=' (with patch)',
153 ) 151 )
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 # and compare the lists of failing tests). 265 # and compare the lists of failing tests).
268 yield ( 266 yield (
269 api.test('too_many_failures_for_retcode') + 267 api.test('too_many_failures_for_retcode') +
270 properties('client.v8.fyi', 'V8-Blink Linux 64') + 268 properties('client.v8.fyi', 'V8-Blink Linux 64') +
271 api.override_step_data(with_patch, 269 api.override_step_data(with_patch,
272 canned_test(passing=False, 270 canned_test(passing=False,
273 num_additional_failures=125)) + 271 num_additional_failures=125)) +
274 api.override_step_data(without_patch, 272 api.override_step_data(without_patch,
275 canned_test(passing=True, minimal=True)) 273 canned_test(passing=True, minimal=True))
276 ) 274 )
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698