Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2175683002: Delete unused NewTabPageView#isAnimatedLogoShowing (Closed)

Created:
4 years, 5 months ago by Michael van Ouwerkerk
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete unused NewTabPageView#isAnimatedLogoShowing BUG=616090 Committed: https://crrev.com/22ee6d724075600dbf4b4226e917355eaf8d62f2 Cr-Commit-Position: refs/heads/master@{#407132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 5 months ago (2016-07-22 10:06:38 UTC) #4
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-22 11:40:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175683002/1
4 years, 5 months ago (2016-07-22 11:41:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 11:44:36 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 11:46:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22ee6d724075600dbf4b4226e917355eaf8d62f2
Cr-Commit-Position: refs/heads/master@{#407132}

Powered by Google App Engine
This is Rietveld 408576698