Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2175653002: Import inspector_protocol via DEPS. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
CC:
dgozman, kozy, pfeldman, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Import inspector_protocol via DEPS. This is not in use yet, but will be soon. R=jochen@chromium.org, machenbach@chromium.org BUG=chromium:580337 Committed: https://crrev.com/871bb72897e7b8897d0b2818b5451333d060eed9 Cr-Commit-Position: refs/heads/master@{#37977}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Yang
Please take a look.
4 years, 5 months ago (2016-07-22 08:55:02 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-22 08:56:03 UTC) #2
Michael Achenbach
lgtm with comments https://codereview.chromium.org/2175653002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/2175653002/diff/1/DEPS#newcode20 DEPS:20: "v8/platform/inspector_protocol": Add to .gitignore? https://codereview.chromium.org/2175653002/diff/1/DEPS#newcode21 DEPS:21: ...
4 years, 5 months ago (2016-07-22 09:46:04 UTC) #7
Yang
On 2016/07/22 09:46:04, Michael Achenbach (slow) wrote: > lgtm with comments > > https://codereview.chromium.org/2175653002/diff/1/DEPS > ...
4 years, 5 months ago (2016-07-22 09:53:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175653002/20001
4 years, 5 months ago (2016-07-22 10:57:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 11:26:47 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 11:29:16 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/871bb72897e7b8897d0b2818b5451333d060eed9
Cr-Commit-Position: refs/heads/master@{#37977}

Powered by Google App Engine
This is Rietveld 408576698