Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2175613004: Add code back to change the status of WebBluetooth chooser once discovery is complete (Closed)

Created:
4 years, 5 months ago by juncai
Modified:
4 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews, ortuno, Jeffrey Yasskin, scheib
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add code back to change the status of WebBluetooth chooser once discovery is complete Some context: https://codereview.chromium.org/1653533002 added code to ItemChooserDialog to notify it that the discovery is complete and no new devices will be added. It also adds a new string to show when the discovery is complete. However, https://codereview.chromium.org/1739523002 accidentally removed this feature. This CL added this feature back. BUG=580346 Committed: https://crrev.com/69820f8d4217aaa02cf0cd928a3d8797d7ac7b0a Cr-Commit-Position: refs/heads/master@{#407668}

Patch Set 1 : added code back to change the status of WebBluetooth chooser once discovery is complete #

Messages

Total messages: 12 (7 generated)
juncai
Please take a look.
4 years, 5 months ago (2016-07-23 02:03:45 UTC) #6
Ted C
lgtm
4 years, 5 months ago (2016-07-26 00:05:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175613004/1
4 years, 5 months ago (2016-07-26 00:26:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 01:13:59 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 01:16:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69820f8d4217aaa02cf0cd928a3d8797d7ac7b0a
Cr-Commit-Position: refs/heads/master@{#407668}

Powered by Google App Engine
This is Rietveld 408576698