Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2175613003: Fix GMOCK WARNING: Uninteresting mock function call - taking default action. (Closed)

Created:
4 years, 5 months ago by pals
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GMOCK WARNING: Uninteresting mock function call - taking default action. BUG=587995 Committed: https://crrev.com/da2fecc7a2f400724b1a4636cbbb63e0c1b8b331 Cr-Commit-Position: refs/heads/master@{#407193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
pals
Following warning is shown while running PaymentRequestTests. This GMOCK warning was introduced in my earlier ...
4 years, 5 months ago (2016-07-22 11:19:21 UTC) #3
please use gerrit instead
Good catch! lgtm
4 years, 5 months ago (2016-07-22 17:38:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175613003/1
4 years, 5 months ago (2016-07-22 17:42:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 17:46:29 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:49:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da2fecc7a2f400724b1a4636cbbb63e0c1b8b331
Cr-Commit-Position: refs/heads/master@{#407193}

Powered by Google App Engine
This is Rietveld 408576698