Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2175603003: Omit frames up to new target in Error constructor (Closed)

Created:
4 years, 5 months ago by jgruber
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Omit frames up to new target in Error constructor BUG=v8:5216 R=yangguo@chromium.org Committed: https://crrev.com/89403e03164ce49e28e382371fb25e1a64d15401 Cr-Commit-Position: refs/heads/master@{#37978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/messages.cc View 1 chunk +12 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-5216.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jgruber
4 years, 5 months ago (2016-07-22 11:19:48 UTC) #5
Yang
lgtm.
4 years, 5 months ago (2016-07-22 11:37:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175603003/1
4 years, 5 months ago (2016-07-22 11:42:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 11:43:40 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 11:45:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89403e03164ce49e28e382371fb25e1a64d15401
Cr-Commit-Position: refs/heads/master@{#37978}

Powered by Google App Engine
This is Rietveld 408576698