Issue 2175593003: Revert "Ensure |m_image| is (re-)created in ImageResource::didAddClient()"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2175593003: Revert "Ensure |m_image| is (re-)created in ImageResource::didAddClient()" (Closed)

Created:
4 years, 5 months ago by hiroshige

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Ensure |m_image| is (re-)created in ImageResource::didAddClient()" This reverts commit c2ef272fdddd2608b0aed1ff0eb0c13fa04d4bc4. BUG=630531, 618597 Committed: https://chromium.googlesource.com/chromium/src/+/89c778d782211fd938439ce14c9331ff603a0631

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -56 lines)			Patch
M	third_party/WebKit/Source/core/fetch/ImageResource.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/ImageResource.cpp	View	2 chunks	+4 lines, -15 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp	View	1 chunk	+0 lines, -37 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hiroshige

4 years, 5 months ago (2016-07-22 07:46:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
89c778d782211fd938439ce14c9331ff603a0631.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages