Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2175583002: SubtleNotificationView: Layout after changing text; ensure it's visible. (Closed)

Created:
4 years, 5 months ago by Matt Giuca
Modified:
4 years, 5 months ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews, tfarina, sky, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SubtleNotificationView: Layout after changing text; ensure it's visible. This is just a precaution as it doesn't seem to have any effect right now, but not doing this has caused trouble in the past (see crbug.com/613324). BUG=613324 Committed: https://crrev.com/9e9ba79e590df945401cb66e48f4ec632874a309 Cr-Commit-Position: refs/heads/master@{#407396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/subtle_notification_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Matt Giuca
Hi Peter: Scott suggested adding Layout() to fix any weirdness with disappearing text (although I ...
4 years, 5 months ago (2016-07-22 03:55:18 UTC) #2
Peter Kasting
LGTM
4 years, 5 months ago (2016-07-22 08:19:25 UTC) #3
sky
LGTM
4 years, 5 months ago (2016-07-22 15:12:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175583002/1
4 years, 5 months ago (2016-07-25 00:53:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 01:33:23 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 01:35:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e9ba79e590df945401cb66e48f4ec632874a309
Cr-Commit-Position: refs/heads/master@{#407396}

Powered by Google App Engine
This is Rietveld 408576698