src/effects/gradients/SkTwoPointConicalGradient.h - Issue 2175563003: Bundle SkShader::asFragmentProcessor arguments in a struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkTwoPointConicalGradient.h

Issue 2175563003: Bundle SkShader::asFragmentProcessor arguments in a struct (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix indentation to be less arbitrary Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkTwoPointConicalGradient.h

diff --git a/src/effects/gradients/SkTwoPointConicalGradient.h b/src/effects/gradients/SkTwoPointConicalGradient.h

index f2102c1472f32b35f0ae6dc79864ac1ddf0e1a16..d16e4bc3c5dbc26a369872619205a49c61a4eca3 100644

--- a/src/effects/gradients/SkTwoPointConicalGradient.h

+++ b/src/effects/gradients/SkTwoPointConicalGradient.h

@@ -57,11 +57,7 @@ public:

SkShader::GradientType asAGradient(GradientInfo* info) const override;

#if SK_SUPPORT_GPU

- sk_sp<GrFragmentProcessor> asFragmentProcessor(GrContext*,

- const SkMatrix&,

- const SkMatrix*,

- SkFilterQuality,

- SkSourceGammaTreatment) const override;

+ sk_sp<GrFragmentProcessor> asFragmentProcessor(const AsFPArgs&) const override;

#endif

bool isOpaque() const override;