Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2175503002: chrome/browser/android: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/browser/android: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=dtrainor@chromium.org BUG=554600 Committed: https://crrev.com/c5999f9e1035f7a7f32c416c080afaa8cb0837f7 Cr-Commit-Position: refs/heads/master@{#407612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/android/data_usage/data_use_tab_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/android/download/chrome_download_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/ntp/most_visited_sites_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-07-22 00:15:33 UTC) #1
David Trainor- moved to gerrit
lgtm
4 years, 5 months ago (2016-07-22 15:57:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175503002/1
4 years, 5 months ago (2016-07-25 21:13:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 22:11:13 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 22:13:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5999f9e1035f7a7f32c416c080afaa8cb0837f7
Cr-Commit-Position: refs/heads/master@{#407612}

Powered by Google App Engine
This is Rietveld 408576698